gfx/d3d10,d3d11,d3d12: Restore sprite-pipeline state before gfx_widgets_frame

When an onscreen overlay was active, gfx_widgets (the fast-forward
indicator, FPS counter, achievement popups, load-progress bars,
etc.) silently rendered nothing on d3d10/d3d11/d3d12.  Same symptom
across all three backends, same root cause: d3dN_render_overlay
clobbers render state that gfx_widgets_frame relies on, and the
state isn't restored before the widget draw.

Specifically, the overlay render path:

  - Binds overlays.vbo (d3d10/d3d11) / overlays.vbo_view (d3d12)
    as the IA-stage vertex buffer.
  - Sets frame.viewport / frame.scissorRect when the overlay is
    not fullscreen (i.e. clamped to the game viewport, not the
    full screen).
  - On d3d12, also leaves sprites.pipe_blend bound — fine for SDR,
    but the OSD-msg block immediately below selects pipe_blend_hdr
    in HDR modes, and widgets need to follow the same selection.

gfx_display_d3dN_draw (the entry point widgets use) writes its
sprite vertices into sprites.vbo via Map(), then issues a Draw()
that reads from whatever vbo is currently bound.  After an
overlay, that's overlays.vbo — so the GPU pulls vertices from the
wrong buffer at the wrong stride and the result is invisible
geometry, even though the widget state machine has run normally
and the sprite buffer contents are correct.  Widgets without an
overlay work because nothing has clobbered the binding the menu
path or the post-frame setup left in place.

Restore the sprite-pipeline state at the top of each widget block,
mirroring the OSD-msg block that follows the widget block in each
of these drivers (which already does this and works for the same
reason):

  - d3d10: viewport, blend state, sprites.vbo.
  - d3d11: viewport, blend state, sprites.vbo (the existing
    viewport-only restore was only a partial fix).
  - d3d12: PSO (HDR-aware), viewport, scissor rect, sprites.vbo_view.

Vulkan and gl1 don't hit this because their overlay render paths
either don't share input bindings with widgets (separate command
buffers / fixed-function state) or they happen to set up widget
state from scratch on every frame.

Reported by users of the Steam Deck / Windows community on builds
where overlay + widgets are both enabled.  Companion to 7d6477b
which fixed the analogous (but different-mechanism — widgets
weren't being rendered at all) bug on d3d8.

Author: LibretroAdmin

gfx/drivers/d3d10.c

@@ -3343,7 +3343,32 @@ static bool d3d10_gfx_frame(
 
 #ifdef HAVE_GFX_WIDGETS
    if (widgets_active)
+   {
+      /* d3d10_render_overlay binds d3d10->overlays.vbo as the
+       * input vertex buffer and may set a non-screen viewport
+       * (d3d10->frame.viewport when the overlay isn't
+       * fullscreen).  gfx_display_d3d10_draw writes its sprite
+       * vertices into d3d10->sprites.vbo via Map() but reads
+       * back from whatever buffer is currently bound, so without
+       * restoring the binding here the widget draws fetch the
+       * wrong vertex stream and silently produce nothing on
+       * screen — the widget state machine still runs, the
+       * sprites still get written, but the Draw() reads from
+       * overlays.vbo instead.  Mirror the OSD-msg block below:
+       * screen viewport, sprite vbo, sprite blend state. */
+      UINT offset = 0;
+      UINT stride = sizeof(d3d10_sprite_t);
+      d3d10->device->lpVtbl->RSSetViewports(d3d10->device,
+            1, &d3d10->viewport);
+      d3d10->device->lpVtbl->OMSetBlendState(d3d10->device,
+            d3d10->blend_enable, NULL,
+            D3D10_DEFAULT_SAMPLE_MASK);
+      d3d10->device->lpVtbl->IASetVertexBuffers(
+            d3d10->device, 0, 1,
+            (D3D10Buffer* const)&d3d10->sprites.vbo,
+            &stride, &offset);
       gfx_widgets_frame(video_info);
+   }
 #endif
 
    if (msg && *msg)

gfx/drivers/d3d11.c

@@ -4746,7 +4746,26 @@ static bool d3d11_gfx_frame(
 #ifdef HAVE_GFX_WIDGETS
    if (widgets_active)
    {
+      /* d3d11_render_overlay binds d3d11->overlays.vbo as the
+       * input vertex buffer and may set a non-screen viewport
+       * (d3d11->frame.viewport when the overlay isn't
+       * fullscreen).  gfx_display_d3d11_draw writes its sprite
+       * vertices into d3d11->sprites.vbo via Map() but reads
+       * back from whatever buffer is currently bound, so without
+       * restoring the binding here the widget draws fetch the
+       * wrong vertex stream and silently produce nothing on
+       * screen — the widget state machine still runs, the
+       * sprites still get written, but the Draw() reads from
+       * overlays.vbo instead.  Mirror the OSD-msg block below:
+       * screen viewport, sprite vbo, sprite blend state. */
+      UINT stride = sizeof(d3d11_sprite_t);
+      UINT offset = 0;
       context->lpVtbl->RSSetViewports(context, 1, &d3d11->viewport);
+      d3d11->context->lpVtbl->OMSetBlendState(d3d11->context,
+            d3d11->blend_enable,
+            NULL, D3D11_DEFAULT_SAMPLE_MASK);
+      context->lpVtbl->IASetVertexBuffers(
+            context, 0, 1, &d3d11->sprites.vbo, &stride, &offset);
       gfx_widgets_frame(video_info);
    }
 #endif

gfx/drivers/d3d12.c

@@ -5796,7 +5796,34 @@ static bool d3d12_gfx_frame(
 
 #ifdef HAVE_GFX_WIDGETS
    if (widgets_active)
+   {
+      /* d3d12_render_overlay binds d3d12->overlays.vbo_view as
+       * the input vertex buffer and may set frame.viewport /
+       * frame.scissorRect (when the overlay isn't fullscreen).
+       * Restore the same sprite-pipeline state the OSD-msg
+       * block below uses, so widget draws land against the
+       * sprite vbo with a screen-space viewport.  Without this
+       * the widget state machine still runs and writes to
+       * sprites.vbo, but the GPU draws read from
+       * overlays.vbo_view → silent no-op on screen, which is
+       * the symptom users see when an overlay is active.
+       *
+       * The PSO has to be reset too even though
+       * d3d12_render_overlay also uses sprites.pipe_blend,
+       * because in HDR mode the OSD block selects
+       * pipe_blend_hdr and we want to match. */
+#ifdef HAVE_DXGI_HDR
+      if (   (d3d12->chain.current_rt_format == DXGI_FORMAT_R10G10B10A2_UNORM)
+          || (d3d12->chain.current_rt_format == DXGI_FORMAT_R16G16B16A16_FLOAT))
+         cmd->lpVtbl->SetPipelineState(cmd, d3d12->sprites.pipe_blend_hdr);
+      else
+#endif
+         cmd->lpVtbl->SetPipelineState(cmd, d3d12->sprites.pipe_blend);
+      cmd->lpVtbl->RSSetViewports(cmd, 1, &d3d12->chain.viewport);
+      cmd->lpVtbl->RSSetScissorRects(cmd, 1, &d3d12->chain.scissorRect);
+      cmd->lpVtbl->IASetVertexBuffers(cmd, 0, 1, &d3d12->sprites.vbo_view);
       gfx_widgets_frame(video_info);
+   }
 #endif
 
    if (msg && *msg)