Commit 345a2ef
committed
Makefile.common: gate RetroArchPlaylistManager.o on HAVE_COCOATOUCH
GCC 4.0 (Xcode 3.1, PowerPC) reports:
In file included from RetroArchPlaylistManager.m:8:
RetroArchPlaylistManager.h:14: error: syntax error before
'AT_NAME' token
Commit cc1a131 gated RetroArchPlaylistManager.m out of the griffin
unity build on non-COCOATOUCH targets, but missed this separate
object entry in Makefile.common, which adds the file to OBJ
unconditionally whenever HAVE_COCOA_COMMON is set (i.e. any Cocoa
build, including macOS desktop).
The qb/make build compiles each .o individually from this OBJ list,
so it never saw the griffin-side gate. RetroArchPlaylistManager
uses Obj-C lightweight generics and nullability macros (Xcode 7+,
2015), which GCC 4.0 can't parse.
Wrap the line in ifeq ($(HAVE_COCOATOUCH), 1). HAVE_COCOATOUCH
isn't currently set anywhere in Makefile.common — iOS builds go
through Xcode projects, not make — so this effectively drops the
file from the desktop make build. The gate leaves the door open
for adding iOS make support later without another round-trip.1 parent 5b9c5dc commit 345a2ef
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2602 | 2602 | | |
2603 | 2603 | | |
2604 | 2604 | | |
2605 | | - | |
2606 | | - | |
| 2605 | + | |
| 2606 | + | |
| 2607 | + | |
| 2608 | + | |
| 2609 | + | |
| 2610 | + | |
| 2611 | + | |
| 2612 | + | |
| 2613 | + | |
2607 | 2614 | | |
2608 | 2615 | | |
2609 | 2616 | | |
| |||
0 commit comments