Small batch of warning fixes

Author: JoeOsborn

command.c

@@ -826,7 +826,7 @@ bool command_seek_replay(command_t *cmd, const char *arg)
    {
       _len = strlcpy(reply, "OK ", sizeof(reply));
       _len += snprintf(reply+_len, sizeof(reply)-_len,
-            "%lld", input_st->bsv_movie_state.seek_target_frame);
+            "%" PRId64, input_st->bsv_movie_state.seek_target_frame);
    }
    else
       _len = strlcpy(reply, "NO", sizeof(reply));

deps/glslang/glslang/glslang/MachineIndependent/SymbolTable.cpp

@@ -308,7 +308,7 @@ TVariable* TVariable::clone() const
 TFunction::TFunction(const TFunction& copyOf) : TSymbol(copyOf)
 {
     for (unsigned int i = 0; i < copyOf.parameters.size(); ++i) {
-        TParameter param;
+        TParameter param = {nullptr, nullptr, nullptr};
         parameters.push_back(param);
         parameters.back().copyParam(copyOf.parameters[i]);
     }

deps/xdelta3/xdelta3-djw.h

@@ -1558,6 +1558,10 @@ djw_decode_1_2 (xd3_stream     *stream,
        * we already know the zero frequencies. */
       if (skip_offset != 0 && n >= skip_offset && values[n-skip_offset] == 0)
 	{
+	/* This diagnostic is triggering on GCC 13.3.0 because of the initial 
+	 * call to djw_decode_1_2 with clen[0], but that code path won't hit 
+	 * this branch. */
+#pragma GCC diagnostic ignored "-Wstringop-overflow"
 	  values[n++] = 0;
 	  continue;
 	}

input/bsv/uint32s_index.c

@@ -17,6 +17,7 @@ uint32s_index_t *uint32s_index_new(size_t object_size, uint8_t commit_interval,
    uint32s_index_t *index = malloc(sizeof(uint32s_index_t));
    index->object_size = object_size;
    index->index = NULL;
+   #pragma GCC diagnostic ignored "-Wtautological-compare"
    RHMAP_FIT(index->index, HASHMAP_CAP);
    index->objects = NULL;
    index->counts = NULL;
@@ -270,8 +271,8 @@ uint32_t *uint32s_index_get(uint32s_index_t *index, uint32_t which)
 void uint32s_index_pop(uint32s_index_t *index)
 {
    uint32_t idx = RBUF_LEN(index->objects)-1;
-   uint32_t *object = RBUF_POP(index->objects);
-   size_t size_bytes = index->object_size * sizeof(uint32_t);
+#pragma GCC diagnostic ignored "-Wunused-value"
+   RBUF_POP(index->objects);
    uint32_t hash = index->hashes[idx];
    struct uint32s_bucket *bucket = RHMAP_PTR(index->index, hash);
    RBUF_RESIZE(index->counts, idx);

libretro-common/file/config_file.c

@@ -1044,7 +1044,7 @@ bool config_get_size_t(config_file_t *conf, const char *key, size_t *in)
    if (entry)
    {
       size_t val = 0;
-      if (sscanf(entry->value, "%" PRI_SIZET, &val) == 1)
+      if (sscanf(entry->value, "%zu", &val) == 1)
       {
          *in = val;
          return true;

libretro-common/include/retro_miscellaneous.h

@@ -510,6 +510,8 @@ typedef struct
 #  endif
 #elif defined(PS2)
 #  define PRI_SIZET "u"
+#elif defined(__emscripten__)
+#  define PRI_SIZET "zu"
 #else
 #  if (SIZE_MAX == 0xFFFF)
 #    define PRI_SIZET "hu"

menu/menu_setting.c

@@ -8005,8 +8005,8 @@ static size_t get_string_representation_input_device_reservation_type(
 static size_t setting_get_string_representation_input_device_reserved_device_name(
         rarch_setting_t *setting, char *s, size_t len)
 {
-   int dev_vendor_id;
-   int dev_product_id;
+   unsigned int dev_vendor_id;
+   unsigned int dev_product_id;
    if (!setting)
       return 0;
    if (string_is_empty(setting->value.target.string))