tasks: extend window/taskbar progress coverage

Build on the task_window_progress_cb helper introduced in d1228e6
and propagate the Win32 taskbar progress overlay (and any other
platform window progress hook) to more long-running user-visible
tasks.

Helper relocation:
 - Move the implementation from task_http.c (HAVE_NETWORKING-gated)
   to task_file_transfer.c (always built), so non-network tasks
   can use it without pulling in HAVE_NETWORKING.
 - Move the prototype in tasks_internal.h out of the HAVE_NETWORKING
   block for the same reason.
 - Drop the duplicated copy in task_database.c
   (task_database_progress_cb) in favour of the shared helper, and
   the now-unused video_display_server.h include alongside it.

New coverage:
 - task_pl_thumbnail_download.c: the system-wide bulk thumbnail
   download task. Long, user-initiated, already drives
   task->progress monotonically across two outer phases.
 - task_cloudsync.c: cloud sync, which can be very long and reports
   progress as files are reconciled.
 - task_core_backup.c: both the backup and restore outer tasks, so
   user-initiated backup/restore of cores reflects on the taskbar.

The single-entry pl_thumbnail outer task and short-running tasks
(decompress, disc scan, playlist manager, menu explore) are left
unchanged for now -- they finish too quickly for the taskbar
indicator to be useful, and adding them is a trivial follow-up if
that turns out to be wrong.

Author: LibretroAdmin

tasks/task_cloudsync.c

@@ -1439,6 +1439,7 @@ static void task_push_cloud_sync_with_mode(int conflict_resolution)
    task->title    = strdup(task_title);
    task->handler  = task_cloud_sync_task_handler;
    task->callback = task_cloud_sync_cb;
+   task->progress_cb = task_window_progress_cb;
 
    task_queue_push(task);
 }

tasks/task_core_backup.c

@@ -35,6 +35,7 @@
 #include "../verbosity.h"
 #include "../core_info.h"
 #include "../core_backup.h"
+#include "tasks_internal.h"
 
 #if defined(RARCH_INTERNAL) && defined(HAVE_MENU)
 #include "../menu/menu_driver.h"
@@ -631,6 +632,7 @@ void *task_push_core_backup(
    task->state            = backup_handle;
    task->title            = strdup(task_title);
    task->progress         = 0;
+   task->progress_cb      = task_window_progress_cb;
 
    if (mute)
       task->flags        |=  RETRO_TASK_FLG_MUTE;
@@ -1085,6 +1087,7 @@ bool task_push_core_restore(const char *backup_path, const char *dir_libretro,
    task->state            = backup_handle;
    task->title            = strdup(task_title);
    task->progress         = 0;
+   task->progress_cb      = task_window_progress_cb;
    task->callback         = cb_task_core_restore;
    task->flags           |= RETRO_TASK_FLG_ALTERNATIVE_LOOK;
 

tasks/task_database.c

@@ -39,7 +39,6 @@
 #include "../playlist.h"
 #include "../configuration.h"
 #include "../ui/ui_companion_driver.h"
-#include "../gfx/video_display_server.h"
 #ifdef HAVE_MENU
 #include "../menu/menu_driver.h"
 #endif
@@ -1667,13 +1666,6 @@ static void scan_results_batch_update_playlists(scan_results_t *sr,
 }
 
 #ifdef HAVE_LIBRETRODB
-static void task_database_progress_cb(retro_task_t *task)
-{
-   if (task)
-      video_display_server_set_window_progress(task->progress,
-            ((task->flags & RETRO_TASK_FLG_FINISHED) > 0));
-}
-
 bool task_push_dbscan(
       const char *playlist_directory, /* always from settings */
       const char *content_database,   /* always from settings */
@@ -2607,8 +2599,8 @@ bool task_push_manual_content_scan(
    task->state                   = manual_scan;
    task->title                   = strdup(task_title);
    task->progress                = 0;
-#ifdef HAVE_LIBRETRODB   
-   task->progress_cb             = task_database_progress_cb;
+#ifdef HAVE_LIBRETRODB
+   task->progress_cb             = task_window_progress_cb;
 #else
    task->progress_cb             = NULL;
 #endif

tasks/task_file_transfer.c

@@ -24,8 +24,29 @@
 #include "task_file_transfer.h"
 #include "tasks_internal.h"
 
+#ifdef RARCH_INTERNAL
+#include "../gfx/video_display_server.h"
+#endif
+
 bool task_image_load_handler(retro_task_t *task);
 
+/* Forward task progress to the platform's window/taskbar progress
+ * indicator (e.g. ITaskbarList3 on Win32). Wire this as a task's
+ * progress_cb to have the desktop reflect that task's progress.
+ *
+ * Lives in this always-built TU (rather than the network-gated
+ * task_http.c where it originated) so non-network tasks -- core
+ * backup, manual content scan, etc. -- can use it without pulling
+ * in HAVE_NETWORKING. */
+void task_window_progress_cb(retro_task_t *task)
+{
+#ifdef RARCH_INTERNAL
+   if (task)
+      video_display_server_set_window_progress(task->progress,
+            ((task->flags & RETRO_TASK_FLG_FINISHED) > 0));
+#endif
+}
+
 /* Default number of nbio_iterate() calls per handler tick.
  * Callers may override by setting nbio->pos_increment to a
  * non-zero value before queuing the task.  A value of 0 (the

tasks/task_http.c

@@ -23,9 +23,6 @@
 #include <retro_timers.h>
 #include <retro_miscellaneous.h>
 
-#ifdef RARCH_INTERNAL
-#include "../gfx/video_display_server.h"
-#endif
 #include "task_file_transfer.h"
 #include "tasks_internal.h"
 
@@ -243,20 +240,6 @@ static bool task_http_finder(retro_task_t *task, void *user_data)
    return false;
 }
 
-/* Forward task progress to the platform's window/taskbar progress
- * indicator (e.g. ITaskbarList3 on Win32). Exposed via tasks_internal.h
- * so non-HTTP tasks (such as the Core Updater's outer aggregating tasks)
- * can wire it as their progress_cb and have the desktop reflect their
- * progress, the same way titled HTTP transfers already do. */
-void task_window_progress_cb(retro_task_t *task)
-{
-#ifdef RARCH_INTERNAL
-   if (task)
-      video_display_server_set_window_progress(task->progress,
-            ((task->flags & RETRO_TASK_FLG_FINISHED) > 0));
-#endif
-}
-
 static void *task_push_http_transfer_generic_titled(
       struct http_connection_t *conn,
       const char *url, bool mute, bool headers_accept_err,

tasks/task_pl_thumbnail_download.c

@@ -617,6 +617,7 @@ bool task_push_pl_thumbnail_download(
    task->state                   = pl_thumb;
    task->title                   = strdup(system);
    task->progress                = 0;
+   task->progress_cb             = task_window_progress_cb;
    task->flags                  |= RETRO_TASK_FLG_ALTERNATIVE_LOOK;
 
    task_queue_push(task);

tasks/tasks_internal.h

@@ -52,6 +52,18 @@ typedef struct nbio_buf
    unsigned bufsize;
 } nbio_buf_t;
 
+/* Generic progress_cb that forwards a task's progress (0-100) to the
+ * platform's window/taskbar progress indicator (e.g. ITaskbarList3 on
+ * Win32). Set this on any task whose progress should be reflected on
+ * the taskbar -- aggregating tasks (e.g. the Core Updater's outer
+ * task) need to do this manually because their inner http transfers
+ * run muted and so their own progress callbacks never fire.
+ *
+ * Available regardless of HAVE_NETWORKING: implementation lives in
+ * task_file_transfer.c so non-network long-running tasks (manual
+ * content scan, core backup, ...) can use it too. */
+void task_window_progress_cb(retro_task_t *task);
+
 #ifdef HAVE_NETWORKING
 typedef struct
 {
@@ -61,14 +73,6 @@ typedef struct
    int status;
 } http_transfer_data_t;
 
-/* Generic progress_cb that forwards a task's progress (0-100) to the
- * platform's window/taskbar progress indicator. Set this on any task
- * whose progress should be reflected on the taskbar -- aggregating
- * tasks (e.g. the Core Updater's outer task) need to do this manually
- * because their inner http transfers run muted and so their own
- * progress callbacks never fire. */
-void task_window_progress_cb(retro_task_t *task);
-
 void *task_push_http_transfer(const char *url, bool mute, const char *type,
       retro_task_callback_t cb, void *userdata);