Fraction setting wraparound rounding correction (#15676)

sonninnos · web-flow · commit 0eeb9f918e8e · 2023-09-05T18:14:04.000-07:00
diff --git a/menu/menu_setting.c b/menu/menu_setting.c
@@ -1083,8 +1083,9 @@ static int setting_fraction_action_left_default(
 
    if (setting->flags & SD_FLAG_ENFORCE_MINRANGE)
    {
-      float min = setting->min;
-      if (*setting->value.target.fraction < min)
+      float min       = setting->min;
+      float half_step = setting->step * 0.5f;
+      if (*setting->value.target.fraction < min - half_step)
       {
          settings_t *settings = config_get_ptr();
          float           max  = setting->max;

Original file line number	Diff line number	Diff line change
`@@ -1083,8 +1083,9 @@ static int setting_fraction_action_left_default(`
`1083`	`1083`
`1084`	`1084`	`if (setting->flags & SD_FLAG_ENFORCE_MINRANGE)`
`1085`	`1085`	`{`
`1086`		`- float min = setting->min;`
`1087`		`- if (*setting->value.target.fraction < min)`
	`1086`	`+ float min = setting->min;`
	`1087`	`+ float half_step = setting->step * 0.5f;`
	`1088`	`+ if (*setting->value.target.fraction < min - half_step)`
`1088`	`1089`	`{`
`1089`	`1090`	`settings_t *settings = config_get_ptr();`
`1090`	`1091`	`float max = setting->max;`