record/avfoundation: use cocoa_defines.h macros instead of rolling our own

libretro-common/include/defines/cocoa_defines.h already provides
RARCH_RELEASE / RARCH_RETAIN / RARCH_AUTORELEASE / RARCH_SUPER_DEALLOC
for ARC/MRR-neutral Objective-C memory management, and is the
established convention across ui_cocoa.m / cocoa_common.m /
ui_cocoatouch.m / dispserv_apple.m / coreaudio.c. The local
RA_RELEASE_OBJ / RA_RELEASE_DQ macros added in b327848 solved the
same problem with ad-hoc spelling. Adopt the project convention.

Changes:

  * libretro-common/include/defines/cocoa_defines.h: add
    RARCH_DISPATCH_RELEASE(x) alongside the existing four macros.
    The GCD variant needs its own spelling because [x release] is a
    compile error on pre-10.8 SDKs where OS_OBJECT_USE_OBJC is 0 and
    dispatch_queue_t is a plain C handle rather than an ObjC object;
    dispatch_release() works uniformly on all MRR-capable SDKs.
    NULL-guarded because dispatch_release(NULL) is explicitly
    undefined (unlike [nil release] which is a defined no-op).

  * record/drivers/record_avfoundation.m: drop the local ~30-line
    macro block, #include <defines/cocoa_defines.h>, and replace
    the five call sites. The project convention splits the release
    and the nil-assignment into two lines rather than bundling them
    into a compound macro; follow suit. Semantics are identical:

      MRC: [field release]; field = nil;
      ARC: ((void)0);       field = nil;  (release happens via the
                                           __strong auto-qualifier
                                           on the struct member
                                           triggered by the assignment)

No behavior change on any build path. The existing tests for the
MRC leak fix from b327848 continue to pass (the ivars end up nil-
valued and the objects released exactly once in both modes).

Camera-side counterpart (camera/drivers/avfoundation.m) does not
need the same treatment: it uses @Property (strong, nonatomic) on
an @interface (clang auto-synthesizes correct MRC retain semantics
from the strong attribute), its private struct ivars are plain C
pointers that ObjC memory management does not apply to, and there
is no -dealloc override.

Author: LibretroAdmin

libretro-common/include/defines/cocoa_defines.h

@@ -97,11 +97,20 @@
 #define RARCH_RELEASE(x)        ((void)0)
 #define RARCH_AUTORELEASE(x)    ((void)0)
 #define RARCH_SUPER_DEALLOC()   ((void)0)
+#define RARCH_DISPATCH_RELEASE(x) ((void)0)
 #else
 #define RARCH_RETAIN(x)         [(x) retain]
 #define RARCH_RELEASE(x)        [(x) release]
 #define RARCH_AUTORELEASE(x)    [(x) autorelease]
 #define RARCH_SUPER_DEALLOC()   [super dealloc]
+/* GCD object release for MRR.  Use dispatch_release() rather than
+ * [x release] because the latter is a compile error on pre-10.8 SDKs
+ * where OS_OBJECT_USE_OBJC is 0 and dispatch_queue_t is a plain C
+ * handle rather than an Objective-C object.  dispatch_release works
+ * uniformly across all MRR-capable SDKs.  NULL-guarded because
+ * dispatch_release(NULL) is explicitly undefined, unlike
+ * [nil release] which is a defined no-op. */
+#define RARCH_DISPATCH_RELEASE(x) do { if (x) dispatch_release(x); } while (0)
 #endif
 
 #endif

record/drivers/record_avfoundation.m

@@ -25,6 +25,7 @@
 #include <string.h>
 
 #include <boolean.h>
+#include <defines/cocoa_defines.h>
 #include <gfx/scaler/scaler.h>
 #include <gfx/video_frame.h>
 #include <string/stdstring.h>
@@ -33,36 +34,6 @@
 #include "../../retroarch.h"
 #include "../../verbosity.h"
 
-/* Release helpers that work identically under MRC and ARC.
- *
- * The ivars on record_avfoundation_t are Objective-C pointers
- * (AVAssetWriter*, AVAssetWriterInput*, etc. and dispatch_queue_t)
- * held in a plain C struct.  Modern clang auto-qualifies ObjC struct
- * members as __strong under ARC, so assignment through them releases
- * the prior value automatically - plain `field = nil` is correct.
- *
- * Under MRC (RetroArch's top-level qb Makefile builds .m files without
- * -fobjc-arc, and so do the RetroArch/_Metal/_OSX107/_iOS13 Xcode
- * projects) no such auto-release happens, so `field = nil` would
- * overwrite a +1-retained pointer and leak the object.  That is the
- * historical behaviour: every record_stop leaked four AVAssetWriter
- * objects and one GCD queue.
- *
- * Fix with the macros below: explicit release on the MRC path,
- * assignment-only on the ARC path.  `[nil release]` is a safe no-op,
- * but `dispatch_release(NULL)` is undefined, so the DQ macro guards.
- *
- * The field expression is evaluated twice by the MRC expansion; all
- * five call sites use a direct struct-member lvalue with no aliasing
- * so this is safe. */
-#if __has_feature(objc_arc)
-#  define RA_RELEASE_OBJ(_x)  do { (_x) = nil; } while (0)
-#  define RA_RELEASE_DQ(_x)   do { (_x) = nil; } while (0)
-#else
-#  define RA_RELEASE_OBJ(_x)  do { [(_x) release]; (_x) = nil; } while (0)
-#  define RA_RELEASE_DQ(_x)   do { if (_x) { dispatch_release(_x); (_x) = nil; } } while (0)
-#endif
-
 typedef struct record_avfoundation
 {
    AVAssetWriter *assetWriter;
@@ -170,11 +141,25 @@ static void avfoundation_release_handle(record_avfoundation_t *handle)
    if (!handle)
       return;
    scaler_ctx_gen_reset(&handle->scaler);
-   RA_RELEASE_OBJ(handle->pixelBufferAdaptor);
-   RA_RELEASE_OBJ(handle->videoInput);
-   RA_RELEASE_OBJ(handle->audioInput);
-   RA_RELEASE_OBJ(handle->assetWriter);
-   RA_RELEASE_DQ (handle->encodingQueue);
+
+   /* Release (MRC) / auto-release (ARC) the owned Objective-C objects,
+    * then clear the field so any subsequent access sees nil rather
+    * than a dangling pointer.  Under ARC the RARCH_RELEASE is a no-op
+    * and the field-assignment-to-nil releases via __strong auto-
+    * qualification; under MRC RARCH_RELEASE sends -release and the
+    * field-assignment-to-nil just overwrites the now-stale pointer.
+    * See libretro-common/include/defines/cocoa_defines.h. */
+   RARCH_RELEASE(handle->pixelBufferAdaptor);
+   handle->pixelBufferAdaptor = nil;
+   RARCH_RELEASE(handle->videoInput);
+   handle->videoInput         = nil;
+   RARCH_RELEASE(handle->audioInput);
+   handle->audioInput         = nil;
+   RARCH_RELEASE(handle->assetWriter);
+   handle->assetWriter        = nil;
+   RARCH_DISPATCH_RELEASE(handle->encodingQueue);
+   handle->encodingQueue      = nil;
+
    free(handle);
 }
 
@@ -373,7 +358,8 @@ static void avfoundation_release_handle(record_avfoundation_t *handle)
          else
          {
             RARCH_WARN("[AVFoundation] Cannot add audio input, continuing without audio\n");
-            RA_RELEASE_OBJ(handle->audioInput);
+            RARCH_RELEASE(handle->audioInput);
+            handle->audioInput = nil;
          }
       }