Additional Sensors for Switch

[moosehadley]

Feature request, enabling the additional sensors for the Nintendo Switch release.

It seems the linux drivers are already present, as the inputs sensors appear in /sys/bus/iio, but the RetroArch input driver present in Lakka does not handle these inputs.

There are some GameBoy Advance games that require these. (WarioWare Twisted, for example)
The RetroArch 'switch' input driver supports all three sensor types, but this input driver isn't present in Lakka. And may not even work, as it seems to rely on official APIs.

I'm not sure what the best route would be for getting these supported in Lakka. A modified input driver maybe?

For reference,

accelerometer
/sys/devices/7000da00.spi/spi_master/spi3/spi3.0/iio:device0

gyroscope
/sys/devices/7000da00.spi/spi_master/spi3/spi3.0/iio:device1

illuminance
/sys/devices/7000c400.i2c/i2c-1/1-0029/iio:device2

[GavinDarkglider]

Please read the README_CONFIG.txt included with the build. There are options for enabling the Ambient Light Sensor. Internal IMU works, just no easy way to tie it to any emulator in RetroArch, and the ones in the controllers are preferable for dock, and tabletop play, in which case you wouldn't be touching the switch, so the internal one is almost useless unless you want bad auto screen rotation. It is enabled by default though.

Also any modifications to RetroArch are beyond the scope of lakka. So asking for a custom input driver for RetroArch should be done in the RetroArch repo.

Also, before you make the assumption it works, or doesn't, try it in RetroArch in switchroot Ubuntu, since those sensors are enabled by default there(if memory serves), and report back if any of them are supported in RetroArch.

[gouchi]

Hi,

Illuminance sensors should be working via this PR.

For gyro and accelerometer, for now it has been added only to SDL2 input/joypad driver via 1 and 2. For udev, we will have to wait for this PR.

Thank you.

[GavinDarkglider]

Hi,

Illuminance sensors should be working via this PR.

For gyro and accelerometer, for now it has been added only to SDL2 input/joypad driver via 1 and 2. For udev, we will have to wait for this PR.

Thank you.

So, I have been testing this, illuminance is indeed broken, at least on switch. For some reason it isn't resolving path to proper iio device, then tries to open node in another devices path, which spams the log with failed to open messages.
Basically iio:device2 is our sensor, but it seems to get stuck on iio:device1, then fails to open node for reading.

I patched in the correct path, and the sensor is working, but mbga core only detects it if you disabled the sensor in core options, before you close core, then re-enable it after launching game, which is probably an mbga issue.

I have also managed to fix udev touch screen detection, but it basically makes the touchscreen a pad mouse(like on a laptop), and doesn't actually seem to do anything else really. But at least it now sees and initializes it, so if that gets updated/finished at some point, it should just work.

[GavinDarkglider]

@gouchi https://github.com/libretro/RetroArch/blob/master/input/common/linux_common.c#L323 should be
return -1.0;

If it is the way it is, it sends success value(initialization illuminance value of 0) and not an error code to the calling function. Doing this causes search loop to start poller on non existent sysfs node, then breaks out of the search loop. In this case we never get proper device.

This doesn't fix the mbga issue where it only works if you change setting from non sensor to sensor after rom launch. If it is set to sensor, it won't work unless you restart core with it being set to non sensor.

[GavinDarkglider]

libretro/RetroArch#18483

Should fix illuminance.....

[GavinDarkglider]

Hi,

Illuminance sensors should be working via this PR.

For gyro and accelerometer, for now it has been added only to SDL2 input/joypad driver via 1 and 2. For udev, we will have to wait for this PR.

Thank you.

Just looking at the comments on the udev pr, this is mainly for gamepad devices, and am not seeing anything specific to gyro/accelerometer in device itself. The switch has these sensors internally, but also has them in the joycons as well. Also from the comments, it doesn't sound like more than the backend is implemented properly.