Merge pull request #673 from Johannesd3/discovery-crate

Create separate discovery crate

Author: roderickvd

.github/workflows/test.yml

@@ -99,8 +99,8 @@ jobs:
       - run: cargo hack  --workspace --remove-dev-deps
       - run: cargo build -p librespot-core --no-default-features
       - run: cargo build -p librespot-core
-      - run: cargo build -p librespot-connect
-      - run: cargo build -p librespot-connect --no-default-features --features with-dns-sd
+      - run: cargo hack build --each-feature -p librespot-discovery
+      - run: cargo hack build --each-feature -p librespot-playback
       - run: cargo hack build --each-feature
 
   test-windows:

CHANGELOG.md

@@ -7,13 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+* [connect], [discovery] The crate `librespot-discovery` for discovery in LAN was created. Its functionality was previously part of `librespot-connect`.
+
 ### Removed
 
 * [librespot-audio] Removed `VorbisDecoder`, `VorbisError`, `AudioPacket`, `PassthroughDecoder`, `PassthroughError`, `AudioError`, `AudioDecoder` and the `convert` module from `librespot_audio`. The underlying crates `vorbis`, `librespot-tremor`, `lewton` and `ogg` should be used directly.
 
 ### Fixed
 
-* [librespot-playback] Incorrect `PlayerConfig::default().normalisation_threshold` caused distortion when using dynamic volume normalisation downstream
+* [librespot-playback] Incorrect `PlayerConfig::default().normalisation_threshold` caused distortion when using dynamic volume normalisation downstream in librespot-connect was deprecated in favor of the `librespot-discovery` crate.
+
+### Deprecated
+* [connect] The `discovery` module.
 
 ## [0.2.0] - 2021-05-04
 

Cargo.lock

@@ -33,6 +33,10 @@ path = "core"
 version = "0.2.0"
 features = ["apresolve"]
 
+[dependencies.librespot-discovery]
+path = "discovery"
+version = "0.2.0"
+
 [dependencies.librespot-metadata]
 path = "metadata"
 version = "0.2.0"
@@ -72,7 +76,7 @@ gstreamer-backend = ["librespot-playback/gstreamer-backend"]
 with-tremor = ["librespot-playback/with-tremor"]
 with-vorbis = ["librespot-playback/with-vorbis"]
 
-with-dns-sd = ["librespot-connect/with-dns-sd"]
+with-dns-sd = ["librespot-discovery/with-dns-sd"]
 
 default = ["rodio-backend"]
 

Cargo.toml

@@ -8,25 +8,15 @@ repository = "https://github.com/librespot-org/librespot"
 edition = "2018"
 
 [dependencies]
-aes-ctr = "0.6"
-base64 = "0.13"
 form_urlencoded = "1.0"
-futures-core = "0.3"
 futures-util = { version = "0.3.5", default_features = false }
-hmac = "0.11"
-hyper = { version = "0.14", features = ["server", "http1", "tcp"] }
-libmdns = "0.6"
 log = "0.4"
 protobuf = "2.14.0"
 rand = "0.8"
 serde = { version = "1.0", features = ["derive"] }
-serde_json = "1.0.25"
-sha-1 = "0.9"
-tokio = { version = "1.0", features = ["macros", "rt", "sync"] }
+serde_json = "1.0"
+tokio = { version = "1.0", features = ["macros", "sync"] }
 tokio-stream = "0.1.1"
-url = "2.1"
-
-dns-sd = { version = "0.1.3", optional = true }
 
 [dependencies.librespot-core]
 path = "../core"
@@ -40,6 +30,9 @@ version = "0.2.0"
 path = "../protocol"
 version = "0.2.0"
 
-[features]
-with-dns-sd = ["dns-sd"]
+[dependencies.librespot-discovery]
+path = "../discovery"
+version = "0.2.0"
 
+[features]
+with-dns-sd = ["librespot-discovery/with-dns-sd"]