Skip to content

Commit d8e8423

Browse files
authored
Fix initial volume showing zero but playing full volume (#1373)
1 parent 1912065 commit d8e8423

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313

1414
### Removed
1515

16+
### Fixed
17+
18+
- [connect] Fixes initial volume showing zero despite playing in full volume instead
19+
1620
## [0.5.0] - 2024-10-15
1721

1822
This version is be a major departure from the architecture up until now. It

connect/src/spirc.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1509,7 +1509,7 @@ impl SpircTask {
15091509
fn set_volume(&mut self, volume: u16) {
15101510
let old_volume = self.device.volume();
15111511
let new_volume = volume as u32;
1512-
if old_volume != new_volume {
1512+
if old_volume != new_volume || self.mixer.volume() != volume {
15131513
self.device.set_volume(new_volume);
15141514
self.mixer.set_volume(volume);
15151515
if let Some(cache) = self.session.cache() {

0 commit comments

Comments
 (0)