Skip to content

Commit d0dd9a7

Browse files
committed
Remve AddToQueue, switch to SetQueue
1 parent 065ca87 commit d0dd9a7

3 files changed

Lines changed: 2 additions & 28 deletions

File tree

connect/src/spirc.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,11 +1115,8 @@ impl SpircTask {
11151115
}
11161116
SetRepeatingTrack(repeat_track) => self.handle_repeat_track(repeat_track.value),
11171117
AddToQueue(add_to_queue) => {
1118-
let track = add_to_queue.track.clone();
11191118
self.connect_state.add_to_queue(add_to_queue.track, true);
1120-
if let Ok(uri) = SpotifyUri::from_uri(&track.uri) {
1121-
self.player.emit_added_to_queue_event(uri);
1122-
}
1119+
self.emit_set_queue_event();
11231120
}
11241121
SetQueue(set_queue) => {
11251122
// Extract track data before consuming set_queue
@@ -1660,10 +1657,7 @@ impl SpircTask {
16601657
..Default::default()
16611658
};
16621659
self.connect_state.add_to_queue(track, true);
1663-
1664-
if let Ok(uri) = SpotifyUri::from_uri(&track_uri) {
1665-
self.player.emit_added_to_queue_event(uri);
1666-
}
1660+
self.emit_set_queue_event();
16671661
}
16681662
}
16691663

playback/src/player.rs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ enum PlayerCommand {
138138
track: bool,
139139
},
140140
EmitAutoPlayChangedEvent(bool),
141-
EmitAddedToQueueEvent(SpotifyUri),
142141
EmitSetQueueEvent {
143142
context_uri: String,
144143
current_track: Option<(String, String)>, // (uri, provider)
@@ -153,9 +152,6 @@ pub enum PlayerEvent {
153152
PlayRequestIdChanged {
154153
play_request_id: u64,
155154
},
156-
AddedToQueue {
157-
track_id: SpotifyUri,
158-
},
159155
// Fired when the player is stopped (e.g. by issuing a "stop" command to the player).
160156
Stopped {
161157
play_request_id: u64,
@@ -665,10 +661,6 @@ impl Player {
665661
self.command(PlayerCommand::EmitAutoPlayChangedEvent(auto_play));
666662
}
667663

668-
pub fn emit_added_to_queue_event(&self, track_id: SpotifyUri) {
669-
self.command(PlayerCommand::EmitAddedToQueueEvent(track_id));
670-
}
671-
672664
pub fn emit_set_queue_event(
673665
&self,
674666
context_uri: String,
@@ -2371,10 +2363,6 @@ impl PlayerInternal {
23712363
self.auto_normalise_as_album = setting
23722364
}
23732365

2374-
PlayerCommand::EmitAddedToQueueEvent(track_id) => {
2375-
self.send_event(PlayerEvent::AddedToQueue { track_id })
2376-
}
2377-
23782366
PlayerCommand::EmitSetQueueEvent {
23792367
context_uri,
23802368
current_track,
@@ -2588,10 +2576,6 @@ impl fmt::Debug for PlayerCommand {
25882576
.debug_tuple("EmitAutoPlayChangedEvent")
25892577
.field(&auto_play)
25902578
.finish(),
2591-
PlayerCommand::EmitAddedToQueueEvent(track_id) => f
2592-
.debug_tuple("EmitAddedToQueueEvent")
2593-
.field(&track_id)
2594-
.finish(),
25952579
PlayerCommand::EmitSetQueueEvent {
25962580
context_uri,
25972581
next_tracks,

src/player_event_handler.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ impl EventHandler {
2727
.insert("PLAYER_EVENT", "play_request_id_changed".to_string());
2828
env_vars.insert("PLAY_REQUEST_ID", play_request_id.to_string());
2929
}
30-
PlayerEvent::AddedToQueue { track_id } => {
31-
env_vars.insert("PLAYER_EVENT", "added_to_queue".to_string());
32-
env_vars.insert("TRACK_ID", track_id.to_id());
33-
}
3430
PlayerEvent::TrackChanged { audio_item } => {
3531
let id = audio_item.track_id.to_id();
3632
env_vars.insert("PLAYER_EVENT", "track_changed".to_string());

0 commit comments

Comments
 (0)