fix: handle dealer reconnect in-place without restarting spirc

Symptoms observed in logs:

  WARN  librespot_core::dealer  Websocket peer does not respond.
  WARN  librespot_connect::spirc  unexpected shutdown
  WARN  librespot  Spirc shut down unexpectedly

When the dealer websocket drops (peer timeout or TLS close_notify),
SpircTask broke out of its event loop so main.rs could tear down and
recreate the entire Spirc. This caused playback to stop on every
transient websocket drop — even though the dealer already
auto-reconnects the websocket.

The subscription streams survive reconnects because they are registered
on the shared DealerShared instance. After reconnect, the server pushes
a new connection_id which handle_connection_id_update already handles.

Changes: reconnect_rx.changed() logs and continues instead of breaking.
handle_connection_id_update errors are non-fatal (logged, not breaking).

After fix — 6 days of logs (Mar 14-20) showing ~20 dealer reconnects
handled in-place without restarting spirc or stopping playback:

  Mar 16 05:06 — "Dealer reconnected; awaiting new connection_id."
  Mar 16 05:06 — "re-registering with active playback state: Paused { ... }"
  [no restart, no "Spirc shut down unexpectedly"]

  Mar 18 12:14 — "Dealer reconnected; awaiting new connection_id."
  Mar 18 12:14 — "re-registering with active playback state: Playing { ... }"
  [playback continued uninterrupted]

  Mar 19 — 9 dealer reconnects in one day, all handled in-place

Summary: 0 spirc restarts from dealer reconnects (vs ~1/day before fix).

Co-authored-by: Copilot <[email protected]>

Author: antoinecellerier

connect/src/spirc.rs

@@ -480,7 +480,6 @@ impl SpircTask {
                     connection_id_update,
                     match |connection_id| if let Err(why) = self.handle_connection_id_update(connection_id).await {
                         error!("failed handling connection id update: {why}");
-                        break;
                     }
                 },
                 // main dealer update of any remote device updates
@@ -588,11 +587,13 @@ impl SpircTask {
                         }
                     }
                 },
-                // dealer reconnected after a connection loss — our subscription
-                // streams are stale, so break out and let main.rs re-create spirc
+                // Dealer reconnected after a connection loss. Our subscription
+                // streams survive because they're registered on the shared
+                // DealerShared — the new websocket dispatches through the same
+                // handlers. A new connection_id will arrive via
+                // connection_id_update and re-register our device state.
                 Ok(()) = reconnect_rx.changed() => {
-                    warn!("Dealer reconnected; restarting spirc to refresh subscriptions.");
-                    break;
+                    info!("Dealer reconnected; awaiting new connection_id.");
                 },
                 else => break
             }