feat(player): Replace position update interval option with sensible default

Author: paulfariello

src/main.rs

@@ -46,6 +46,9 @@ mod mpris_event_handler;
 #[cfg(feature = "with-mpris")]
 use mpris_event_handler::MprisEventHandler;
 
+// Position update interval set to 400ms (Doherty threshold)
+const POSITION_UPDATE_INTERVAL_MS: Duration = Duration::from_millis(400);
+
 fn device_id(name: &str) -> String {
     HEXLOWER.encode(&Sha1::digest(name.as_bytes()))
 }
@@ -275,7 +278,6 @@ async fn get_setup() -> Setup {
     #[cfg(feature = "passthrough-decoder")]
     const PASSTHROUGH: &str = "passthrough";
     const PASSWORD: &str = "password";
-    const POSITION_UPDATE_INTERVAL: &str = "position-update-interval";
     const PROXY: &str = "proxy";
     const QUIET: &str = "quiet";
     const SYSTEM_CACHE: &str = "system-cache";
@@ -322,7 +324,6 @@ async fn get_setup() -> Setup {
     #[cfg(feature = "passthrough-decoder")]
     const PASSTHROUGH_SHORT: &str = "P";
     const PASSWORD_SHORT: &str = "p";
-    const POSITION_UPDATE_INTERVAL_SHORT: &str = ""; // no short flag
     const EMIT_SINK_EVENTS_SHORT: &str = "Q";
     const QUIET_SHORT: &str = "q";
     const INITIAL_VOLUME_SHORT: &str = "R";
@@ -634,12 +635,6 @@ async fn get_setup() -> Setup {
         "Knee width (dB) of the dynamic limiter from 0.0 to 10.0. Defaults to 5.0.",
         "KNEE",
     )
-    .optopt(
-        POSITION_UPDATE_INTERVAL_SHORT,
-        POSITION_UPDATE_INTERVAL,
-        "Maximum interval in ms for player to send a position event. Defaults to no forced position update.",
-        "POSITION_UPDATE",
-    )
     .optopt(
         ZEROCONF_PORT_SHORT,
         ZEROCONF_PORT,
@@ -1826,22 +1821,6 @@ async fn get_setup() -> Setup {
             },
         };
 
-        let position_update_interval = opt_str(POSITION_UPDATE_INTERVAL).as_deref().map(
-            |position_update| match position_update.parse::<u64>() {
-                Ok(value) => Duration::from_millis(value),
-                _ => {
-                    invalid_error_msg(
-                        POSITION_UPDATE_INTERVAL,
-                        POSITION_UPDATE_INTERVAL_SHORT,
-                        position_update,
-                        "Integer value in ms",
-                        "None",
-                    );
-                    exit(1);
-                }
-            },
-        );
-
         #[cfg(feature = "passthrough-decoder")]
         let passthrough = opt_present(PASSTHROUGH);
         #[cfg(not(feature = "passthrough-decoder"))]
@@ -1860,7 +1839,7 @@ async fn get_setup() -> Setup {
             normalisation_release_cf,
             normalisation_knee_db,
             ditherer,
-            position_update_interval: None,
+            position_update_interval: Some(POSITION_UPDATE_INTERVAL_MS),
             local_file_directories,
         }
     };