Merge pull request #785 from roderickvd/revert-round-half-to-even

roderickvd · web-flow · commit 33c07f0e2b66 · 2021-06-01T08:17:28.000+02:00
Revert `math::round_half_to_even`
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/playback/Cargo.toml b/playback/Cargo.toml
@@ -20,7 +20,6 @@ version = "0.2.0"
 [dependencies]
 futures-executor = "0.3"
 futures-util = { version = "0.3", default_features = false, features = ["alloc"] }
-libmath = "0.2"
 log = "0.4"
 byteorder = "1.4"
 shell-words = "1.0.0"
@@ -59,4 +58,4 @@ jackaudio-backend = ["jack"]
 rodio-backend = ["rodio", "cpal", "thiserror"]
 rodiojack-backend = ["rodio", "cpal/jack", "thiserror"]
 sdl-backend = ["sdl2"]
-gstreamer-backend = ["gstreamer", "gstreamer-app", "glib"]
+gstreamer-backend = ["gstreamer", "gstreamer-app", "glib"]
diff --git a/playback/src/convert.rs b/playback/src/convert.rs
@@ -63,8 +63,7 @@ impl Converter {
 
         // Casting float to integer rounds towards zero by default, i.e. it
         // truncates, and that generates larger error than rounding to nearest.
-        // Absolute lowest error is gained from rounding ties to even.
-        math::round::half_to_even(int_value, 0)
+        int_value.round()
     }
 
     // Special case for samples packed in a word of greater bit depth (e.g.

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,7 @@ impl Converter {`
`63`	`63`
`64`	`64`	`// Casting float to integer rounds towards zero by default, i.e. it`
`65`	`65`	`// truncates, and that generates larger error than rounding to nearest.`
`66`		`- // Absolute lowest error is gained from rounding ties to even.`
`67`		`- math::round::half_to_even(int_value, 0)`
	`66`	`+ int_value.round()`
`68`	`67`	`}`
`69`	`68`
`70`	`69`	`// Special case for samples packed in a word of greater bit depth (e.g.`