Clean up + removed deprecated JsonParser methods

devgianlu · devgianlu · commit d31400379c14 · 2020-01-12T12:52:04.000+01:00
diff --git a/api/src/main/java/xyz/gianlu/librespot/api/handlers/PlayerHandler.java b/api/src/main/java/xyz/gianlu/librespot/api/handlers/PlayerHandler.java
@@ -147,7 +147,7 @@ private enum Command {
         NEXT("next"), PREV("prev"), SET_VOLUME("set-volume"),
         VOLUME_UP("volume-up"), VOLUME_DOWN("volume-down"), CURRENT("current");
 
-        private String name;
+        private final String name;
 
         Command(String name) {
             this.name = name;
diff --git a/core/src/main/java/xyz/gianlu/librespot/BytesArrayList.java b/core/src/main/java/xyz/gianlu/librespot/BytesArrayList.java
@@ -118,9 +118,6 @@ public int read(@NotNull byte[] b, int off, int len) {
 
             int i = 0;
             while (true) {
-                if (sub >= elementData.length)
-                    return i;
-
                 int copy = Math.min(len - i, elementData[sub].length - offset);
                 System.arraycopy(elementData[sub], offset, b, off + i, copy);
                 i += copy;
diff --git a/core/src/main/java/xyz/gianlu/librespot/core/ApResolver.java b/core/src/main/java/xyz/gianlu/librespot/core/ApResolver.java
@@ -22,7 +22,6 @@
  * @author Gianlu
  */
 public class ApResolver {
-    private static final JsonParser PARSER = new JsonParser();
     private static final String BASE_URL = "http://apresolve.spotify.com/";
     private static final Map<String, List<String>> pool = new HashMap<>(3);
     private static final Logger LOGGER = Logger.getLogger(ApResolver.class);
@@ -54,7 +53,7 @@ private static Map<String, List<String>> request(@NotNull String... types) throw
         conn.connect();
 
         try {
-            JsonObject obj = PARSER.parse(new InputStreamReader(conn.getInputStream())).getAsJsonObject();
+            JsonObject obj = JsonParser.parseReader(new InputStreamReader(conn.getInputStream())).getAsJsonObject();
             HashMap<String, List<String>> map = new HashMap<>();
             for (String type : types)
                 map.put(type, getUrls(obj, type));
diff --git a/core/src/main/java/xyz/gianlu/librespot/core/FacebookAuthenticator.java b/core/src/main/java/xyz/gianlu/librespot/core/FacebookAuthenticator.java
@@ -23,7 +23,6 @@
  */
 public class FacebookAuthenticator implements Closeable {
     private static final URL LOGIN_SPOTIFY;
-    private static final JsonParser PARSER = new JsonParser();
     private static final Logger LOGGER = Logger.getLogger(FacebookAuthenticator.class);
     private static final byte[] EOL = new byte[]{'\r', '\n'};
 
@@ -44,7 +43,7 @@ public class FacebookAuthenticator implements Closeable {
         HttpURLConnection conn = (HttpURLConnection) LOGIN_SPOTIFY.openConnection();
         try {
             conn.connect();
-            JsonObject obj = PARSER.parse(new InputStreamReader(conn.getInputStream())).getAsJsonObject();
+            JsonObject obj = JsonParser.parseReader(new InputStreamReader(conn.getInputStream())).getAsJsonObject();
             credentialsUrl = obj.get("credentials_url").getAsString();
             String loginUrl = obj.get("login_url").getAsString();
             LOGGER.info(String.format("Visit %s in your browser.", loginUrl));
@@ -73,7 +72,7 @@ public void close() throws IOException {
     }
 
     private void authData(@NotNull String json) {
-        JsonObject obj = PARSER.parse(json).getAsJsonObject();
+        JsonObject obj = JsonParser.parseString(json).getAsJsonObject();
         if (!obj.get("error").isJsonNull()) {
             LOGGER.fatal("Error during authentication: " + obj.get("error"));
             return;
diff --git a/core/src/main/java/xyz/gianlu/librespot/core/SearchManager.java b/core/src/main/java/xyz/gianlu/librespot/core/SearchManager.java
@@ -16,7 +16,6 @@
  */
 public class SearchManager {
     private static final String BASE_URL = "hm://searchview/km/v4/search/";
-    private static final JsonParser PARSER = new JsonParser();
     private final Session session;
 
     public SearchManager(@NotNull Session session) {
@@ -34,7 +33,7 @@ public JsonObject request(@NotNull SearchRequest req) throws IOException {
 
         if (resp.statusCode != 200) throw new SearchException(resp.statusCode);
 
-        return (JsonObject) PARSER.parse(new InputStreamReader(resp.payload.stream()));
+        return JsonParser.parseReader(new InputStreamReader(resp.payload.stream())).getAsJsonObject();
     }
 
     public static class SearchException extends IOException {
diff --git a/core/src/main/java/xyz/gianlu/librespot/core/Session.java b/core/src/main/java/xyz/gianlu/librespot/core/Session.java
@@ -643,8 +643,8 @@ static Inner from(@NotNull AbsConfiguration configuration) {
      */
     public static class Builder {
         private final Inner inner;
+        private final AuthConfiguration authConf;
         private Authentication.LoginCredentials loginCredentials = null;
-        private AuthConfiguration authConf;
 
         public Builder(@NotNull Connect.DeviceType deviceType, @NotNull String deviceName, @NotNull AbsConfiguration configuration) {
             this.inner = new Inner(deviceType, deviceName, configuration);
diff --git a/core/src/main/java/xyz/gianlu/librespot/core/TimeProvider.java b/core/src/main/java/xyz/gianlu/librespot/core/TimeProvider.java
@@ -23,7 +23,6 @@
 public final class TimeProvider {
     private static final AtomicLong offset = new AtomicLong(0);
     private static final Logger LOGGER = Logger.getLogger(TimeProvider.class);
-    private static final JsonParser PARSER = new JsonParser();
     private static Method method = Method.NTP;
 
     private TimeProvider() {
@@ -99,7 +98,7 @@ private static void updateMelody(@NotNull Session session) {
             ResponseBody body = resp.body();
             if (body == null) throw new IllegalStateException();
 
-            JsonObject obj = PARSER.parse(body.string()).getAsJsonObject();
+            JsonObject obj = JsonParser.parseString(body.string()).getAsJsonObject();
             long diff = obj.get("timestamp").getAsLong() - System.currentTimeMillis();
             synchronized (offset) {
                 offset.set(diff);
diff --git a/core/src/main/java/xyz/gianlu/librespot/crypto/DiffieHellman.java b/core/src/main/java/xyz/gianlu/librespot/crypto/DiffieHellman.java
@@ -11,7 +11,7 @@
  */
 public class DiffieHellman {
     private static final BigInteger GENERATOR = BigInteger.valueOf(2);
-    private static final byte PRIME_BYTES[] = {
+    private static final byte[] PRIME_BYTES = {
             (byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xc9, (byte)
             (byte) 0x0f, (byte) 0xda, (byte) 0xa2, (byte) 0x21, (byte) 0x68, (byte) 0xc2, (byte) 0x34, (byte) 0xc4, (byte) 0xc6, (byte)
             (byte) 0x62, (byte) 0x8b, (byte) 0x80, (byte) 0xdc, (byte) 0x1c, (byte) 0xd1, (byte) 0x29, (byte) 0x02, (byte) 0x4e, (byte)
diff --git a/core/src/main/java/xyz/gianlu/librespot/dealer/DealerClient.java b/core/src/main/java/xyz/gianlu/librespot/dealer/DealerClient.java
@@ -28,7 +28,6 @@
  * @author Gianlu
  */
 public class DealerClient implements Closeable {
-    private static final JsonParser PARSER = new JsonParser();
     private static final Logger LOGGER = Logger.getLogger(DealerClient.class);
     private final Looper looper = new Looper();
     private final Session session;
@@ -314,7 +313,7 @@ public void onOpen(@NotNull WebSocket ws, @NotNull Response response) {
 
             @Override
             public void onMessage(@NotNull WebSocket ws, @NotNull String text) {
-                JsonObject obj = PARSER.parse(text).getAsJsonObject();
+                JsonObject obj = JsonParser.parseString(text).getAsJsonObject();
 
                 waitForListeners();
 
diff --git a/core/src/main/java/xyz/gianlu/librespot/mercury/JsonMercuryRequest.java b/core/src/main/java/xyz/gianlu/librespot/mercury/JsonMercuryRequest.java
@@ -12,7 +12,6 @@
  * @author Gianlu
  */
 public class JsonMercuryRequest<W extends JsonWrapper> {
-    private static final JsonParser PARSER = new JsonParser();
     final RawMercuryRequest request;
     private final Class<W> wrapperClass;
 
@@ -24,7 +23,7 @@ public class JsonMercuryRequest<W extends JsonWrapper> {
     @NotNull
     public W instantiate(@NotNull MercuryClient.Response resp) {
         try {
-            JsonElement elm = PARSER.parse(new InputStreamReader(resp.payload.stream()));
+            JsonElement elm = JsonParser.parseReader(new InputStreamReader(resp.payload.stream()));
             return wrapperClass.getConstructor(JsonObject.class).newInstance(elm.getAsJsonObject());
         } catch (InstantiationException | IllegalAccessException | InvocationTargetException | NoSuchMethodException ex) {
             throw new IllegalArgumentException(ex);
diff --git a/core/src/main/java/xyz/gianlu/librespot/player/PagesLoader.java b/core/src/main/java/xyz/gianlu/librespot/player/PagesLoader.java
@@ -22,7 +22,6 @@
  * @author Gianlu
  */
 public final class PagesLoader {
-    private static final JsonParser PARSER = new JsonParser();
     private final List<ContextPage> pages;
     private final Session session;
     private String resolveUrl = null;
@@ -55,7 +54,7 @@ private List<ContextTrack> fetchTracks(@NotNull String url) throws IOException {
         MercuryClient.Response resp = session.mercury().sendSync(RawMercuryRequest.newBuilder()
                 .setUri(url).setMethod("GET").build());
 
-        JsonObject obj = PARSER.parse(new InputStreamReader(resp.payload.stream())).getAsJsonObject();
+        JsonObject obj = JsonParser.parseReader(new InputStreamReader(resp.payload.stream())).getAsJsonObject();
         return ProtoUtils.jsonToContextTracks(obj.getAsJsonArray("tracks"));
     }
 
diff --git a/core/src/main/java/xyz/gianlu/librespot/player/StateWrapper.java b/core/src/main/java/xyz/gianlu/librespot/player/StateWrapper.java
@@ -48,7 +48,6 @@
  */
 public class StateWrapper implements DeviceStateHandler.Listener, DealerClient.MessageListener {
     private static final Logger LOGGER = Logger.getLogger(StateWrapper.class);
-    private static final JsonParser PARSER = new JsonParser();
 
     static {
         try {
@@ -175,7 +174,7 @@ private void loadTransforming() {
                 return;
             }
 
-            if (body != null) updateContext(PARSER.parse(body.string()).getAsJsonObject());
+            if (body != null) updateContext(JsonParser.parseString(body.string()).getAsJsonObject());
             else throw new IllegalArgumentException();
 
             LOGGER.debug("Updated context with transforming information!");
@@ -631,7 +630,7 @@ else if (op.getKind() == Playlist4ApiProto.Op.Kind.REM)
             List<String> added = null;
             List<String> removed = null;
 
-            JsonArray items = PARSER.parse(payloads[0]).getAsJsonObject().getAsJsonArray("items");
+            JsonArray items = JsonParser.parseString(payloads[0]).getAsJsonObject().getAsJsonArray("items");
             for (JsonElement elm : items) {
                 JsonObject obj = elm.getAsJsonObject();
                 String itemUri = "spotify:" + obj.get("type").getAsString() + ":" + obj.get("identifier").getAsString();
diff --git a/core/src/main/java/xyz/gianlu/librespot/player/contexts/AbsSpotifyContext.java b/core/src/main/java/xyz/gianlu/librespot/player/contexts/AbsSpotifyContext.java
@@ -34,7 +34,7 @@ else if (context.startsWith("spotify:search:"))
 
     @Override
     public String toString() {
-        return "AbsSpotifyContext{context='" + context + "\'}";
+        return "AbsSpotifyContext{context='" + context + "'}";
     }
 
     public abstract boolean isFinite();
diff --git a/core/src/main/java/xyz/gianlu/librespot/player/crossfade/CrossfadeController.java b/core/src/main/java/xyz/gianlu/librespot/player/crossfade/CrossfadeController.java
@@ -11,7 +11,6 @@
 import java.util.Map;
 
 public class CrossfadeController {
-    private final static JsonParser PARSER = new JsonParser();
     private static final Logger LOGGER = Logger.getLogger(CrossfadeController.class);
     private final int trackDuration;
     private final int defaultFadeDuration;
@@ -55,13 +54,13 @@ public CrossfadeController(int duration, @NotNull Map<String, String> metadata,
 
         fadeInDuration = Integer.parseInt(metadata.getOrDefault("audio.fade_in_duration", "-1"));
         fadeInStartTime = Integer.parseInt(metadata.getOrDefault("audio.fade_in_start_time", "-1"));
-        JsonArray fadeInCurves = PARSER.parse(metadata.getOrDefault("audio.fade_in_curves", "[]")).getAsJsonArray();
+        JsonArray fadeInCurves = JsonParser.parseString(metadata.getOrDefault("audio.fade_in_curves", "[]")).getAsJsonArray();
         if (fadeInCurves.size() > 1) throw new UnsupportedOperationException(fadeInCurves.toString());
 
         fadeOutUri = metadata.get("audio.fade_out_uri");
         fadeOutDuration = Integer.parseInt(metadata.getOrDefault("audio.fade_out_duration", "-1"));
         fadeOutStartTime = Integer.parseInt(metadata.getOrDefault("audio.fade_out_start_time", "-1"));
-        JsonArray fadeOutCurves = PARSER.parse(metadata.getOrDefault("audio.fade_out_curves", "[]")).getAsJsonArray();
+        JsonArray fadeOutCurves = JsonParser.parseString(metadata.getOrDefault("audio.fade_out_curves", "[]")).getAsJsonArray();
         if (fadeOutCurves.size() > 1) throw new UnsupportedOperationException(fadeOutCurves.toString());
 
 
diff --git a/core/src/main/java/xyz/gianlu/librespot/player/decrypt/AesAudioDecrypt.java b/core/src/main/java/xyz/gianlu/librespot/player/decrypt/AesAudioDecrypt.java
@@ -26,8 +26,6 @@ public AesAudioDecrypt(byte[] key) {
     public synchronized void decryptChunk(int chunkIndex, byte[] in, byte[] out) throws IOException {
         int pos = CHUNK_SIZE * chunkIndex;
 
-        if (pos % 16 != 0) throw new IllegalArgumentException("Position not multiple of 16: " + pos);
-
         try {
             Cipher cipher = Cipher.getInstance("AES/CTR/NoPadding");
             cipher.init(Cipher.ENCRYPT_MODE, secretKeySpec, new IvParameterSpec(Utils.toByteArray(IV_INT.add(BigInteger.valueOf(pos / 16)))));
