Minimize audio pop when using owntone with metadata pipe (fixes #389)

devgianlu · devgianlu · commit 88149a2b55f1 · 2021-10-23T14:25:27.000+02:00
diff --git a/player/src/main/java/xyz/gianlu/librespot/player/Player.java b/player/src/main/java/xyz/gianlu/librespot/player/Player.java
@@ -981,7 +981,6 @@ public void onContextChanged(@NotNull Player player, @NotNull String newUri) {
 
                     @Override
                     public void onTrackChanged(@NotNull Player player, @NotNull PlayableId id, @Nullable MetadataWrapper metadata, boolean userInitiated) {
-                        if (userInitiated) dacpPipe.sendPipeFlush();
                     }
 
                     @Override
@@ -1052,6 +1051,7 @@ public void onStartedLoading(@NotNull Player player) {
 
                     @Override
                     public void onFinishedLoading(@NotNull Player player) {
+                        dacpPipe.sendPipeFlush();
                     }
                 });
             }

Original file line number	Diff line number	Diff line change
`@@ -981,7 +981,6 @@ public void onContextChanged(@NotNull Player player, @NotNull String newUri) {`
`981`	`981`
`982`	`982`	`@Override`
`983`	`983`	`public void onTrackChanged(@NotNull Player player, @NotNull PlayableId id, @Nullable MetadataWrapper metadata, boolean userInitiated) {`
`984`		`- if (userInitiated) dacpPipe.sendPipeFlush();`
`985`	`984`	`}`
`986`	`985`
`987`	`986`	`@Override`
`@@ -1052,6 +1051,7 @@ public void onStartedLoading(@NotNull Player player) {`
`1052`	`1051`
`1053`	`1052`	`@Override`
`1054`	`1053`	`public void onFinishedLoading(@NotNull Player player) {`
	`1054`	`+ dacpPipe.sendPipeFlush();`
`1055`	`1055`	`}`
`1056`	`1056`	`});`
`1057`	`1057`	`}`