Skip to content

Commit 8170def

Browse files
committed
Additional logging to debug #277
1 parent 276a460 commit 8170def

3 files changed

Lines changed: 12 additions & 2 deletions

File tree

player/src/main/java/xyz/gianlu/librespot/player/Player.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,8 @@ private void panicState(@Nullable PlaybackMetrics.Reason reason) {
222222
* @param play Whether the playback should start immediately
223223
*/
224224
private void loadSession(@NotNull String sessionId, boolean play, boolean withSkip) {
225+
LOGGER.debug("Loading session, id: {}, play: {}", sessionId, play);
226+
225227
TransitionInfo trans = TransitionInfo.contextChange(state, withSkip);
226228

227229
if (playerSession != null) {
@@ -248,6 +250,7 @@ private void loadSession(@NotNull String sessionId, boolean play, boolean withSk
248250
private void loadTrack(boolean play, @NotNull TransitionInfo trans) {
249251
endMetrics(playerSession.currentPlaybackId(), trans.endedReason, playerSession.currentMetrics(), trans.endedWhen);
250252

253+
LOGGER.debug("Loading track, id: {}, session: {}, playback: {}, play: {}", state.getCurrentPlayable(), playerSession.sessionId(), playerSession.currentPlaybackId(), play);
251254
String playbackId = playerSession.play(state.getCurrentPlayableOrThrow(), state.getPosition(), trans.startedReason);
252255
state.setPlaybackId(playbackId);
253256
session.eventService().sendEvent(new NewPlaybackIdEvent(state.getSessionId(), playbackId));

player/src/main/java/xyz/gianlu/librespot/player/StateWrapper.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ private synchronized void enrichWithMetadata(@NotNull Metadata.Track track) {
346346
if (track.hasPopularity()) builder.putMetadata("popularity", String.valueOf(track.getPopularity()));
347347
if (track.hasExplicit()) builder.putMetadata("is_explicit", String.valueOf(track.getExplicit()));
348348
if (track.hasHasLyrics()) builder.putMetadata("has_lyrics", String.valueOf(track.getHasLyrics()));
349-
if (track.hasName()) builder.putMetadata("title", String.valueOf(track.getName()));
349+
if (track.hasName()) builder.putMetadata("title", track.getName());
350350
if (track.hasDiscNumber()) builder.putMetadata("album_disc_number", String.valueOf(track.getDiscNumber()));
351351

352352
for (int i = 0; i < track.getArtistCount(); i++) {
@@ -405,7 +405,7 @@ private synchronized void enrichWithMetadata(@NotNull Metadata.Episode episode)
405405

406406
ProvidedTrack.Builder builder = state.getTrackBuilder();
407407
if (episode.hasExplicit()) builder.putMetadata("is_explicit", String.valueOf(episode.getExplicit()));
408-
if (episode.hasName()) builder.putMetadata("title", String.valueOf(episode.getName()));
408+
if (episode.hasName()) builder.putMetadata("title", episode.getName());
409409

410410
if (episode.hasShow()) {
411411
Metadata.Show show = episode.getShow();
@@ -1055,6 +1055,7 @@ synchronized void initializeFrom(@NotNull TrackFinder finder, @Nullable ContextT
10551055
List<ContextTrack> newTracks = pages.currentPage();
10561056
int index = finder.find(newTracks);
10571057
if (index == -1) {
1058+
LOGGER.trace("Did not find track, going to next page, finder: {}", finder);
10581059
tracks.addAll(newTracks);
10591060
continue;
10601061
}
@@ -1063,6 +1064,7 @@ synchronized void initializeFrom(@NotNull TrackFinder finder, @Nullable ContextT
10631064
tracks.addAll(newTracks);
10641065

10651066
setCurrentTrackIndex(index);
1067+
LOGGER.trace("Initialized current track index to {}, finder: {}", index, finder);
10661068
break;
10671069
} else {
10681070
cannotLoadMore = true;

player/src/main/java/xyz/gianlu/librespot/player/playback/PlayerSession.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,11 @@ public String currentPlaybackId() {
335335
else return queue.head().playbackId;
336336
}
337337

338+
@NotNull
339+
public String sessionId() {
340+
return sessionId;
341+
}
342+
338343
/**
339344
* Close the session by clearing the queue which will close all entries.
340345
*/

0 commit comments

Comments
 (0)