Added play pause toggle command to the API (#244)

* Added play pause to the api

* Added play pause to the api

* Refactored + removed useless method

Co-authored-by: Gianlu <[email protected]>

Author: brnold

api/README.md

@@ -11,6 +11,7 @@ All the endpoints will respond with `200` if successful or:
 
 ### Player
 - `POST /player/load` Load a track from a given URI. The request body should contain two parameters: `uri` and `play`.
+- `POST /player/play-pause` Toggle play/pause status. Useful when using a remote.
 - `POST /player/pause` Pause playback.
 - `POST /player/resume` Resume playback.
 - `POST /player/next` Skip to next track.

api/src/main/java/xyz/gianlu/librespot/api/handlers/PlayerHandler.java

@@ -179,6 +179,9 @@ protected void handleRequest(@NotNull HttpServerExchange exchange, @NotNull Sess
             case LOAD:
                 load(exchange, session, Utils.getFirstString(params, "uri"), Utils.getFirstBoolean(params, "play"));
                 return;
+            case PLAY_PAUSE:
+                session.player().playPause();
+                return;
             case PAUSE:
                 session.player().pause();
                 return;
@@ -209,7 +212,7 @@ protected void handleRequest(@NotNull HttpServerExchange exchange, @NotNull Sess
     }
 
     private enum Command {
-        LOAD("load"), PAUSE("pause"), RESUME("resume"), TRACKS("tracks"),
+        LOAD("load"), PLAY_PAUSE("play-pause"), PAUSE("pause"), RESUME("resume"), TRACKS("tracks"),
         NEXT("next"), PREV("prev"), SET_VOLUME("set-volume"), SEEK("seek"),
         VOLUME_UP("volume-up"), VOLUME_DOWN("volume-down"), CURRENT("current"),
         ADD_TO_QUEUE("addToQueue"), REMOVE_FROM_QUEUE("removeFromQueue");

core/src/main/java/xyz/gianlu/librespot/player/Player.java

@@ -110,6 +110,11 @@ public void play() {
         handleResume();
     }
 
+    public void playPause() {
+        if (state.isPaused()) handleResume();
+        else handlePause();
+    }
+
     public void pause() {
         handlePause();
     }
@@ -362,7 +367,7 @@ private void handleResume() {
     }
 
     private void handlePause() {
-        if (state.isPlaying()) {
+        if (!state.isPaused()) {
             state.setState(true, true, false);
             sink.pause(false);
 
@@ -536,7 +541,7 @@ private void endMetrics(String playbackId, @NotNull PlaybackMetrics.Reason reaso
 
     @Override
     public void startedLoading() {
-        if (state.isPlaying()) {
+        if (!state.isPaused()) {
             state.setBuffering(true);
             state.updated();
         }

core/src/main/java/xyz/gianlu/librespot/player/StateWrapper.java

@@ -133,10 +133,6 @@ synchronized void setState(boolean playing, boolean paused, boolean buffering) {
             setPosition(state.getPositionAsOfTimestamp());
     }
 
-    boolean isPlaying() {
-        return state.getIsPlaying() && !state.getIsPaused();
-    }
-
     boolean isPaused() {
         return state.getIsPlaying() && state.getIsPaused();
     }