tsan weak_from_this race (#248)

Signed-off-by: turuslan <[email protected]>

Author: turuslan

include/libp2p/protocol/kademlia/impl/content_routing_table.hpp

@@ -28,6 +28,8 @@ namespace libp2p::protocol::kademlia {
   struct ContentRoutingTable {
     virtual ~ContentRoutingTable() = default;
 
+    virtual void start() = 0;
+
     virtual void addProvider(const ContentId &key,
                              const peer::PeerId &peer) = 0;
 

include/libp2p/protocol/kademlia/impl/content_routing_table_impl.hpp

@@ -57,6 +57,8 @@ namespace libp2p::protocol::kademlia {
 
     ~ContentRoutingTableImpl() override;
 
+    void start() override;
+
     std::vector<PeerId> getProvidersFor(const ContentId &key,
                                         size_t limit = 0) const override;
 

src/protocol/kademlia/impl/content_routing_table_impl.cpp

@@ -19,9 +19,10 @@ namespace libp2p::protocol::kademlia {
       : config_(config), scheduler_(scheduler), bus_(std::move(bus)) {
     BOOST_ASSERT(bus_ != nullptr);
     table_ = std::make_unique<Table>();
+  }
 
-    cleanup_timer_ =
-        scheduler_.scheduleWithHandle([this] { setTimerCleanup(); });
+  void ContentRoutingTableImpl::start() {
+    setTimerCleanup();
   }
 
   ContentRoutingTableImpl::~ContentRoutingTableImpl() = default;

src/protocol/kademlia/impl/kademlia_impl.cpp

@@ -64,6 +64,8 @@ namespace libp2p::protocol::kademlia {
     }
     started_ = true;
 
+    content_routing_table_->start();
+
     // save himself into peer repo
     addPeer(host_->getPeerInfo(), true);