Merge pull request #5823 from akolson/fix-native_name-conundrum

Fix TypeError in LanguageDropdown when used in multiple mode

Author: bjester

contentcuration/contentcuration/frontend/shared/views/LanguageDropdown.vue

@@ -113,6 +113,13 @@
     },
     methods: {
       languageText(item) {
+        // VAutocomplete eagerly evaluates getText(internalValue) as a fallback arg to
+        // getValue, even when that fallback isn't needed. In multiple mode, internalValue
+        // is an Array, so languageText receives the array directly. Return early to avoid
+        // calling .split() on undefined.
+        if (Array.isArray(item)) {
+          return '';
+        }
         const firstNativeName = item.native_name.split(',')[0].trim();
         return this.$tr('languageItemText', { language: firstNativeName, code: item.id });
       },

contentcuration/contentcuration/frontend/shared/views/__tests__/languageDropdown.spec.js

@@ -81,4 +81,15 @@ describe('languageDropdown', () => {
     const item = { native_name: '', id: 'de' };
     expect(wrapper.vm.languageText(item)).toBe(' (de)');
   });
+
+  it('returns empty string when called with an array (multiple mode VAutocomplete internal call)', () => {
+    const wrapper = shallowMount(LanguageDropdown, {
+      mocks: {
+        $tr: (key, params) => `${params.language} (${params.code})`,
+      },
+    });
+    // VAutocomplete eagerly evaluates getText(internalValue) as a fallback to getValue.
+    // In multiple mode, internalValue is an Array, so languageText receives the array.
+    expect(wrapper.vm.languageText(['en', 'fr'])).toBe('');
+  });
 });