add FILES_DELIMITER constants for popup_get_file(multiple_files=True)

Author: kujirahand

TkEasyGUI/dialogs.py

@@ -42,8 +42,6 @@
 POPUP_OK_BUTTON_WIDTH = 12
 POPUP_CANCEL_BUTTON_WIDTH = 9
 POPUP_TTK_BUTTONS = True  # use ttk buttons
-# delimiter for multiple files, used in popup_get_file with multiple_files=True
-POPUP_FILES_DELIMITER = "|" if is_win() else ";"
 
 
 def popup_set_options(
@@ -716,25 +714,27 @@ def popup_get_file(
     default_extension: Optional[str] = None,
     files_delimiter: Optional[
         str
-    ] = POPUP_FILES_DELIMITER,  # delimiter for multiple files, used when multiple_files=True
+    ] = None,  # default is FILES_DELIMITER for multiple files, used when multiple_files=True
     # pylint: disable=unused-argument
     no_window: Optional[bool] = None,  # for compatibility
     **kw,
-) -> Union[str, tuple[str], None]:
+) -> Optional[str]:
     """Popup a file selection dialog. Return the file selected."""
+    from . import widgets as eg
+
     if title is None:
         title = message
     if initial_folder is None:
         initial_folder = os.getcwd()
     if file_types is None:
         file_types = [("All Files", "*.*")]
+    if files_delimiter is None:
+        files_delimiter = eg.FILES_DELIMITER
     # check no_window
     if no_window is None:
         no_window = True
     if no_window is False:
         # --- no_window is False ---
-        from . import widgets as eg
-
         # show base dialog
         layout_no_window: list[list[eg.Element]] = [
             [eg.Text(message)],
@@ -785,8 +785,7 @@ def popup_get_file(
             **kw,
         )
     if multiple_files and isinstance(result, (tuple, list)):
-        if files_delimiter is not None:
-            result = files_delimiter.join(result)
+        result = str(files_delimiter).join(result)
     return result
 
 

TkEasyGUI/widgets.py

@@ -94,6 +94,9 @@
     "y2": 22 + 6,
 }  # for macOS titlebar
 
+# delimiter for multiple files, used in popup_get_file with multiple_files=True
+FILES_DELIMITER = "|" if utils.is_win() else ":"
+
 
 # ------------------------------------------------------------------------------
 # Widget wrapper
@@ -4688,7 +4691,7 @@ def __init__(
         save_as: bool = False,
         enable_events: bool = False,  # enable changing events
         # other
-        files_delimiter: Optional[str] = "|",
+        files_delimiter: Optional[str] = FILES_DELIMITER,
         metadata: Union[dict[str, Any], None] = None,
         **kw,
     ) -> None:
@@ -4769,7 +4772,9 @@ def show_dialog(self, *args) -> Union[Any, None]:
                 # Keep popup_get_file return value unchanged (tuple/list) while
                 # updating target widgets/events with a readable string.
                 fallback_delimiter = " "
-                target_value = fallback_delimiter.join(str(item) for item in target_value)
+                target_value = fallback_delimiter.join(
+                    str(item) for item in target_value
+                )
         if (target is not None) and (target_value is not None) and (target_value != ""):
             target.update(target_value)  # type: ignore [call-arg]
             if self.enable_events:

tests/popup/popup_get_file_sp_file_types.py

@@ -4,20 +4,19 @@
 
 import TkEasyGUI as eg
 
-FILES_DELIMITER = "|"
-
 # file types
-file_types = (
+file_types = [
     ("Image files", "*.jpg;*.jpeg;*.jpe;*.heic;*.png;*.gif"),
     ("All files", "*.*"),
-)
+]
 # popup
-files = eg.popup_get_file(
+files_str = eg.popup_get_file(
     "Please select images.",
     file_types=file_types,
     multiple_files=True,
-    files_delimiter=FILES_DELIMITER,
+    files_delimiter=eg.FILES_DELIMITER,
 )
-print(f"raw={files}")
-if files not in (None, ""):
-    print(files.split(FILES_DELIMITER))
+print(f"Selected: {files_str}")
+if files_str:
+    files = files_str.split(eg.FILES_DELIMITER)
+    eg.popup_listbox(files, "Selected Files")

tests/popup/select_multiple_files.py

@@ -2,19 +2,19 @@
 
 import TkEasyGUI as eg
 
-FILES_DELIMITER = "|"
-
 selected_files = eg.popup_get_file(
     "Please select files.",
     title="Select Multiple Files",
     multiple_files=True,
-    files_delimiter=FILES_DELIMITER,
+    files_delimiter=eg.FILES_DELIMITER,
 )
 
 if selected_files in (None, ""):
     print("No files selected.")
 else:
     print(f"raw={selected_files}")
     print("split:")
-    for index, file_path in enumerate(str(selected_files).split(FILES_DELIMITER), start=1):
+    for index, file_path in enumerate(
+        str(selected_files).split(eg.FILES_DELIMITER), start=1
+    ):
         print(f"  {index}. {file_path}")