Skip to content

Commit fc7d6dd

Browse files
committed
fix DeepSource issue(s)
1 parent bd71ecd commit fc7d6dd

2 files changed

Lines changed: 34 additions & 22 deletions

File tree

librespot/audio/decoders.py

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,25 @@ class AudioQuality(enum.Enum):
1515

1616
@staticmethod
1717
def get_quality(audio_format: AudioFile.Format) -> AudioQuality:
18-
if (audio_format == AudioFile.MP3_96
19-
or audio_format == AudioFile.OGG_VORBIS_96
20-
or audio_format == AudioFile.AAC_24_NORM):
18+
if audio_format in [
19+
AudioFile.MP3_96,
20+
AudioFile.OGG_VORBIS_96,
21+
audio_format == AudioFile.AAC_24_NORMAL,
22+
]:
2123
return AudioQuality.NORMAL
22-
if (audio_format == AudioFile.MP3_160
23-
or audio_format == AudioFile.MP3_160_ENC
24-
or audio_format == AudioFile.OGG_VORBIS_160
25-
or audio_format == AudioFile.AAC_24):
24+
if audio_format in [
25+
AudioFile.MP3_160,
26+
AudioFile.MP3_160_ENC,
27+
AudioFile.OGG_VORBIS_160,
28+
AudioFile.AAC_24,
29+
]:
2630
return AudioQuality.HIGH
27-
if (audio_format == AudioFile.MP3_320
28-
or audio_format == AudioFile.MP3_256
29-
or audio_format == AudioFile.OGG_VORBIS_320
30-
or audio_format == AudioFile.AAC_48):
31+
if audio_format in [
32+
AudioFile.MP3_320,
33+
AudioFile.MP3_256,
34+
AudioFile.OGG_VORBIS_320,
35+
AudioFile.AAC_48,
36+
]:
3137
return AudioQuality.VERY_HIGH
3238
raise RuntimeError("Unknown format: {}".format(format))
3339

librespot/audio/format.py

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,24 @@ class SuperAudioFormat(enum.Enum):
99

1010
@staticmethod
1111
def get(audio_format: Metadata.AudioFile.Format):
12-
if audio_format == Metadata.AudioFile.Format.OGG_VORBIS_96 or \
13-
audio_format == Metadata.AudioFile.Format.OGG_VORBIS_160 or \
14-
audio_format == Metadata.AudioFile.Format.OGG_VORBIS_320:
12+
if audio_format in [
13+
Metadata.AudioFile.Format.OGG_VORBIS_96,
14+
Metadata.AudioFile.Format.OGG_VORBIS_160,
15+
Metadata.AudioFile.Format.OGG_VORBIS_320,
16+
]:
1517
return SuperAudioFormat.VORBIS
16-
if audio_format == Metadata.AudioFile.Format.MP3_256 or \
17-
audio_format == Metadata.AudioFile.Format.MP3_320 or \
18-
audio_format == Metadata.AudioFile.Format.MP3_160 or \
19-
audio_format == Metadata.AudioFile.Format.MP3_96 or \
20-
audio_format == Metadata.AudioFile.Format.MP3_160_ENC:
18+
if audio_format in [
19+
Metadata.AudioFile.Format.MP3_256,
20+
Metadata.AudioFile.Format.MP3_320,
21+
Metadata.AudioFile.Format.MP3_160,
22+
Metadata.AudioFile.Format.MP3_96,
23+
Metadata.AudioFile.Format.MP3_160_ENC,
24+
]:
2125
return SuperAudioFormat.MP3
22-
if audio_format == Metadata.AudioFile.Format.AAC_24 or \
23-
audio_format == Metadata.AudioFile.Format.AAC_48 or \
24-
audio_format == Metadata.AudioFile.Format.AAC_24_NORM:
26+
if audio_format in [
27+
Metadata.AudioFile.Format.AAC_24,
28+
Metadata.AudioFile.Format.AAC_48,
29+
Metadata.AudioFile.Format.AAC_24_NORM,
30+
]:
2531
return SuperAudioFormat.AAC
2632
raise RuntimeError("Unknown audio format: {}".format(audio_format))

0 commit comments

Comments
 (0)