migrate to ts

kimxogus · kimxogus · commit 95291906b417 · 2025-10-05T01:37:41.000+09:00
diff --git a/.gitignore b/.gitignore
@@ -7,7 +7,7 @@ node_modules
 npm-debug.log*
 .vscode
 lerna-debug.log
-flow-typed/npm
+
 test-results
 
 *.pbxuser
diff --git a/.prettierignore b/.prettierignore
@@ -1,4 +1,3 @@
-/flow-typed/
 /node_modules/
 package.json
 /test-results/
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -3,22 +3,6 @@
   "workspaces": [
     "packages/*"
   ],
-  "scripts": {
-    "lint": "eslint packages --ext .js,.jsx --ignore-pattern 'node_modules/**'",
-    "lint:fix": "eslint packages --ext .js,.jsx --ignore-pattern 'node_modules/**' --fix",
-    "format": "prettier --write \"**/*.{js,jsx,json,md}\"",
-    "format:check": "prettier --check \"**/*.{js,jsx,json,md}\"",
-    "flow": "flow",
-    "pretest": "npm run lint",
-    "test": "npm run test:android && npm run test:ios",
-    "test:ci": "JEST_JUNIT_OUTPUT=test-results/jest-android.xml npm run test:android --ci --testResultsProcessor='jest-junit' && JEST_JUNIT_OUTPUT=test-results/jest-ios.xml npm run test:ios --ci --testResultsProcessor='jest-junit'",
-    "test:coverage": "jest --coverage --coverageDirectory test-results/coverage --collectCoverageOnlyFrom packages/**/*",
-    "test:android": "cross-env RNVC_DEVICE=android babel-node scripts/test",
-    "test:ios": "cross-env RNVC_DEVICE=ios babel-node scripts/test",
-    "test:watch": "babel-node scripts/test --watch",
-    "prepublishOnly": "npm run test",
-    "prepare": "husky install"
-  },
   "prepare": "husky install",
   "lint-staged": {
     "*.{js,jsx}": [
@@ -49,7 +33,11 @@
     "@babel/core": "^7.7.2",
     "@babel/eslint-parser": "^7.28.4",
     "@babel/node": "^7.7.0",
+
     "@react-native/babel-preset": "^0.73.16",
+    "@types/jest": "^30.0.0",
+    "@types/lodash": "^4.14.194",
+    "@types/node": "^24.0.0",
     "@types/semver": "^7.7.1",
     "babel-core": "7.0.0-bridge.0",
     "babel-jest": "^30.2.0",
@@ -60,8 +48,7 @@
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-react-native": "^5.0.0",
-    "flow-bin": "^0.112.0",
-    "flow-typed": "^2.6.2",
+
     "husky": "^9.1.7",
     "isomorphic-fetch": "^3.0.0",
     "jest": "^30.2.0",
@@ -71,12 +58,31 @@
     "lint-staged": "^16.2.3",
     "pre-commit": "^1.0.10",
     "prettier": "^2.8.8",
-    "promise": "^8.0.3"
+    "promise": "^8.0.3",
+    "ts-node": "^10.9.1",
+    "typescript": "^5.5.6"
+  },
+  "scripts": {
+    "lint": "eslint packages --ext .js,.jsx --ignore-pattern 'node_modules/**'",
+    "lint:fix": "eslint packages --ext .js,.jsx --ignore-pattern 'node_modules/**' --fix",
+    "format": "prettier --write \"**/*.{js,jsx,json,md}\"",
+  "format:check": "prettier --check \"**/*.{js,jsx,json,md}\"",
+    "pretest": "npm run lint",
+    "test": "npm run test:android && npm run test:ios",
+    "test:ci": "JEST_JUNIT_OUTPUT=test-results/jest-android.xml npm run test:android --ci --testResultsProcessor='jest-junit' && JEST_JUNIT_OUTPUT=test-results/jest-ios.xml npm run test:ios --ci --testResultsProcessor='jest-junit'",
+    "test:coverage": "jest --coverage --coverageDirectory test-results/coverage --collectCoverageOnlyFrom packages/**/*",
+    "test:android": "cross-env RNVC_DEVICE=android babel-node scripts/test",
+    "test:ios": "cross-env RNVC_DEVICE=ios babel-node scripts/test",
+    "test:watch": "babel-node scripts/test --watch",
+    "prepublishOnly": "npm run test",
+    "prepare": "husky install",
+
+  "typecheck": "tsc --noEmit"
   },
   "jest": {
     "testEnvironment": "node",
     "testPathIgnorePatterns": [
-      "[/\\\\](build|docs|node_modules|scripts|examples)[/\\\\]"
+      "[/\\\\](build|docs|node_modules|scripts|examples|backups)[/\\\\]"
     ],
     "automock": false,
     "setupFiles": [
diff --git a/packages/react-native-version-check-expo/index.ts b/packages/react-native-version-check-expo/index.ts
@@ -1,4 +1,5 @@
-// @flow
+// @ts-nocheck
+
 import builder from 'react-native-version-check/builder';
 import VersionInfo from './src/ExpoVersionInfo';
 
diff --git a/packages/react-native-version-check-expo/src/ExpoVersionInfo.ts b/packages/react-native-version-check-expo/src/ExpoVersionInfo.ts
@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { Platform } from 'react-native';
 import Constants from 'expo-constants';
 import * as Localization from 'expo-localization';
diff --git a/packages/react-native-version-check/builder.ts b/packages/react-native-version-check/builder.ts
@@ -1,4 +1,5 @@
-// @flow
+// @ts-nocheck
+
 import { getLatestVersion } from './src/getLatestVersion';
 import needUpdate from './src/needUpdate';
 import { setVersionInfo, type IVersionInfo } from './src/versionInfo';
diff --git a/packages/react-native-version-check/index.ts b/packages/react-native-version-check/index.ts
@@ -1,4 +1,5 @@
-// @flow
+// @ts-nocheck
+
 import VersionInfo from './src/RNVersionInfo';
 import builder, { type ReactNativeVersionCheck } from './builder';
 
diff --git a/packages/react-native-version-check/src/RNVersionInfo.ts b/packages/react-native-version-check/src/RNVersionInfo.ts
@@ -1,4 +1,5 @@
-// @flow
+// @ts-nocheck
+
 const RNVersionCheck = require('react-native').NativeModules.RNVersionCheck;
 
 export default {
diff --git a/packages/react-native-version-check/src/__tests__/getLatestVersion.ts b/packages/react-native-version-check/src/__tests__/getLatestVersion.ts
@@ -1,3 +1,4 @@
+// @ts-nocheck
 jest.mock('react-native');
 
 import { setVersionInfo } from '../versionInfo';
diff --git a/packages/react-native-version-check/src/__tests__/needUpdate.ts b/packages/react-native-version-check/src/__tests__/needUpdate.ts
@@ -1,3 +1,4 @@
+// @ts-nocheck
 jest.mock('react-native');
 
 import { setVersionInfo } from '../versionInfo';
diff --git a/packages/react-native-version-check/src/__tests__/versionInfo.ts b/packages/react-native-version-check/src/__tests__/versionInfo.ts
@@ -1,3 +1,4 @@
+// @ts-nocheck
 jest.mock('react-native');
 
 import VersionInfo from '../RNVersionInfo';
diff --git a/packages/react-native-version-check/src/getLatestVersion.ts b/packages/react-native-version-check/src/getLatestVersion.ts
@@ -1,4 +1,4 @@
-// @flow
+// @ts-nocheck
 import { Platform } from 'react-native';
 import isNil from 'lodash/isNil';
 import isFunction from 'lodash/isFunction';
diff --git a/packages/react-native-version-check/src/getStoreUrl.ts b/packages/react-native-version-check/src/getStoreUrl.ts
@@ -1,4 +1,4 @@
-// @flow
+// @ts-nocheck
 import { Platform } from 'react-native';
 import isNil from 'lodash/isNil';
 import { getVersionInfo } from './versionInfo';
diff --git a/packages/react-native-version-check/src/needUpdate.ts b/packages/react-native-version-check/src/needUpdate.ts
@@ -1,4 +1,4 @@
-// @flow
+// @ts-nocheck
 import semver from 'semver';
 import isNil from 'lodash/isNil';
 
diff --git a/packages/react-native-version-check/src/providers/__tests__/playStore.ts b/packages/react-native-version-check/src/providers/__tests__/playStore.ts
@@ -0,0 +1,134 @@
+// @ts-nocheck
+import PlayStoreProvider from '../playStore';
+
+const options = {
+  packageName: 'com.myapp',
+};
+
+const storeUrl =
+  'https://play.google.com/store/apps/details?id=com.myapp&hl=en&gl=US';
+
+const mockSuccesfulResponse = returnBody => {
+  global.fetch = jest.fn().mockImplementationOnce(
+    () =>
+      new Promise(resolve => {
+        resolve(new Response(returnBody));
+      })
+  );
+};
+
+describe('PlayStoreProvider get version from older Play Store layouts', () => {
+  it('get version from older (since ~Apr, 2018) Play Store layout', async () => {
+    mockSuccesfulResponse(
+      '\
+      <html>\
+      <div class="hAyfc">\
+        <div class="BgcNfc">\
+            Current Version\
+        </div>\
+        <span class="htlgb">\
+          <div>\
+            <span class="htlgb">0.10.0</span>\
+          </div>\
+        </span>\
+      </div>\
+      </html>\
+    '
+    );
+
+    await PlayStoreProvider.getVersion(options).then(r =>
+      expect(r).toEqual({ version: '0.10.0', storeUrl })
+    );
+  });
+
+  it('get version from ancient (prior to ~Apr, 2018) Play Store layout', async () => {
+    mockSuccesfulResponse(
+      '\
+      <html>\
+      <div class="hAyfc">\
+        <div class="BgcNfc">\
+            Current Version\
+        </div>\
+        <span class="htlgb">\
+            <span class="softwareVersion">0.10.0</span>\
+        </span>\
+      </div>\
+      </html>\
+    '
+    );
+
+    await PlayStoreProvider.getVersion(options).then(r =>
+      expect(r).toEqual({ version: '0.10.0', storeUrl })
+    );
+  });
+});
+
+describe('PlayStoreProvider get version current (since ~Dec, 2018) Play Store', () => {
+  it('with format x.x.x', async () => {
+    mockSuccesfulResponse(
+      '\
+      <html>\
+      <div class="hAyfc">\
+        <div class="BgcNfc">\
+            Current Version\
+        </div>\
+        <span class="htlgb">\
+          <div class="IQ1z0d">\
+            <span class="htlgb">0.10.0</span>\
+          </div>\
+        </span>\
+      </div>\
+      </html>\
+    '
+    );
+
+    await PlayStoreProvider.getVersion(options).then(r =>
+      expect(r).toEqual({ version: '0.10.0', storeUrl })
+    );
+  });
+
+  it('with format xxx', async () => {
+    mockSuccesfulResponse(
+      '\
+      <html>\
+      <div class="hAyfc">\
+        <div class="BgcNfc">\
+            Current Version\
+        </div>\
+        <span class="htlgb">\
+          <div class="IQ1z0d">\
+            <span class="htlgb">234</span>\
+          </div>\
+        </span>\
+      </div>\
+      </html>\
+    '
+    );
+
+    await PlayStoreProvider.getVersion(options).then(r =>
+      expect(r).toEqual({ version: '234', storeUrl })
+    );
+  });
+});
+
+describe('PlayStoreProvider get version current (since ~May, 2022) Play Store', () => {
+  it('with format x.x.x', async () => {
+    mockSuccesfulResponse(
+      'null,null,[[null,1]],null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,[2],null,[[["0.10.0"]],[[[30,"11"]],[[[16,"4.1"]]]],[["May 31, 2022"]]]'
+    );
+
+    await PlayStoreProvider.getVersion(options).then(r =>
+      expect(r).toEqual({ version: '0.10.0', storeUrl })
+    );
+  });
+
+  it('with format xxx', async () => {
+    mockSuccesfulResponse(
+      'null,null,[[null,1]],null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,[2],null,[[["234"]],[[[30,"11"]],[[[16,"4.1"]]]],[["May 31, 2022"]]]'
+    );
+
+    await PlayStoreProvider.getVersion(options).then(r =>
+      expect(r).toEqual({ version: '234', storeUrl })
+    );
+  });
+});
diff --git a/packages/react-native-version-check/src/providers/appStore.ts b/packages/react-native-version-check/src/providers/appStore.ts
@@ -1,24 +1,21 @@
-// @flow
 import { getVersionInfo } from '../versionInfo';
 
 import { IProvider, IVersionAndStoreUrl } from './types';
 
 export type AppStoreGetVersionOption = {
-  country?: string,
-  packageName?: string,
-  fetchOptions?: any,
-  ignoreErrors?: boolean,
+  country?: string;
+  packageName?: string;
+  fetchOptions?: any;
+  ignoreErrors?: boolean;
 };
 
 export interface IAppStoreProvider extends IProvider {
-  getVersion: AppStoreGetVersionOption => Promise<IVersionAndStoreUrl>;
+  getVersion(option?: AppStoreGetVersionOption): Promise<IVersionAndStoreUrl | undefined>;
 }
 
 class AppStoreProvider implements IProvider {
-  async getVersion(
-    option: AppStoreGetVersionOption
-  ): Promise<IVersionAndStoreUrl> {
-    const opt = option;
+  async getVersion(option?: AppStoreGetVersionOption): Promise<IVersionAndStoreUrl | undefined> {
+    const opt = option || {};
     try {
       if (!opt.country) {
         opt.country = await getVersionInfo().getCountry();
diff --git a/packages/react-native-version-check/src/providers/index.ts b/packages/react-native-version-check/src/providers/index.ts
@@ -1,4 +1,5 @@
-// @flow
+// @ts-nocheck
+
 export { default as playStore } from './playStore';
 export * from './playStore';
 export { default as appStore } from './appStore';
diff --git a/packages/react-native-version-check/src/providers/playStore.ts b/packages/react-native-version-check/src/providers/playStore.ts
@@ -1,16 +1,15 @@
-// @flow
 import { getVersionInfo } from '../versionInfo';
 
 import { IProvider, IVersionAndStoreUrl } from './types';
 
 export type PlayStoreGetVersionOption = {
-  packageName?: string,
-  fetchOptions?: any,
-  ignoreErrors?: boolean,
+  packageName?: string;
+  fetchOptions?: any;
+  ignoreErrors?: boolean;
 };
 
 export interface IPlayStoreProvider extends IProvider {
-  getVersion: PlayStoreGetVersionOption => Promise<IVersionAndStoreUrl>;
+  getVersion(option?: PlayStoreGetVersionOption): Promise<IVersionAndStoreUrl | undefined>;
 }
 
 function error(text: string) {
@@ -22,7 +21,7 @@ function error(text: string) {
 }
 
 class PlayStoreProvider implements IProvider {
-  getVersion(option: PlayStoreGetVersionOption): Promise<IVersionAndStoreUrl> {
+  getVersion(option?: PlayStoreGetVersionOption): Promise<IVersionAndStoreUrl | undefined> {
     const opt = option || {};
     try {
       if (!opt.packageName) {
@@ -58,6 +57,7 @@ class PlayStoreProvider implements IProvider {
     } catch (e) {
       if (opt.ignoreErrors) {
         console.warn(e);
+        return Promise.resolve(undefined);
       } else {
         throw e;
       }
diff --git a/packages/react-native-version-check/src/providers/types.ts b/packages/react-native-version-check/src/providers/types.ts
@@ -1,9 +1,8 @@
-// @flow
-export interface IProvider {
-  getVersion: any => Promise<string>;
-}
-
 export interface IVersionAndStoreUrl {
   version: string;
   storeUrl: string;
 }
+
+export interface IProvider {
+  getVersion(option?: any): Promise<IVersionAndStoreUrl | undefined>;
+}
diff --git a/packages/react-native-version-check/src/versionInfo.ts b/packages/react-native-version-check/src/versionInfo.ts
@@ -1,4 +1,4 @@
-// @flow
+// @ts-nocheck
 export interface IVersionInfo {
   getCountry: () => Promise<string>;
   getPackageName: () => string;
diff --git a/tsconfig.json b/tsconfig.json

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/flow-typed/`
`2`	`1`	`/node_modules/`
`3`	`2`	`package.json`
`4`	`3`	`/test-results/`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// @ts-nocheck`
`1`	`2`	`import { Platform } from 'react-native';`
`2`	`3`	`import Constants from 'expo-constants';`
`3`	`4`	`import * as Localization from 'expo-localization';`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// @ts-nocheck`
`1`	`2`	`jest.mock('react-native');`
`2`	`3`
`3`	`4`	`import { setVersionInfo } from '../versionInfo';`