Set dowloaded files to be executable (#69)

This matches the behavior of bin-wrapper 3.0

Fixes #67

Author: realityking

index.js

@@ -1,6 +1,7 @@
 'use strict';
 const fs = require('fs');
 const path = require('path');
+const url = require('url');
 const pify = require('pify');
 const importLazy = require('import-lazy')(require);
 
@@ -10,6 +11,7 @@ const download = importLazy('download');
 const osFilterObj = importLazy('os-filter-obj');
 
 const statAsync = pify(fs.stat);
+const chmodAsync = pify(fs.chmod);
 
 /**
  * Initialize a new `BinWrapper`
@@ -173,8 +175,34 @@ module.exports = class BinWrapper {
 
 		return Promise.all(urls.map(url => download(url, this.dest(), {
 			extract: true,
-			mode: '755',
 			strip: this.options.strip
-		})));
+		}))).then(result => {
+			const resultingFiles = flatten(result.map((item, index) => {
+				if (Array.isArray(item)) {
+					return item.map(file => file.path);
+				}
+
+				const parsedUrl = url.parse(files[index].url);
+				const parsedPath = path.parse(parsedUrl.pathname);
+
+				return parsedPath.base;
+			}));
+
+			return Promise.all(resultingFiles.map(fileName => {
+				return chmodAsync(path.join(this.dest(), fileName), 0o755);
+			}));
+		});
 	}
 };
+
+function flatten(arr) {
+	return arr.reduce((acc, elem) => {
+		if (Array.isArray(elem)) {
+			acc.push(...elem);
+		} else {
+			acc.push(elem);
+		}
+
+		return acc;
+	}, []);
+}

package.json

@@ -34,6 +34,7 @@
 	},
 	"devDependencies": {
 		"ava": "*",
+		"executable": "^4.1.1",
 		"nock": "^9.4.2",
 		"path-exists": "^3.0.0",
 		"rimraf": "^2.6.2",

test.js

@@ -6,9 +6,9 @@ import pify from 'pify';
 import rimraf from 'rimraf';
 import test from 'ava';
 import tempy from 'tempy';
+import executable from 'executable';
 import Fn from '.';
 
-const fsP = pify(fs);
 const rimrafP = pify(rimraf);
 const fixture = path.join.bind(path, __dirname, 'fixtures');
 
@@ -93,7 +93,7 @@ test('download files even if they are not used', async t => {
 		.use(process.platform === 'win32' ? 'gifsicle.exe' : 'gifsicle');
 
 	await bin.run();
-	const files = await fsP.readdirSync(bin.dest());
+	const files = fs.readdirSync(bin.dest());
 
 	t.is(files.length, 3);
 	t.is(files[0], 'gifsicle');
@@ -121,3 +121,20 @@ test('error if no binary is found and no source is provided', async t => {
 
 	await t.throws(bin.run(), 'No binary found matching your system. It\'s probably not supported.');
 });
+
+test('downloaded files are set to be executable', async t => {
+	const bin = new Fn({strip: 0, skipCheck: true})
+		.src('http://foo.com/gifsicle-darwin.tar.gz')
+		.src('http://foo.com/gifsicle-win32.tar.gz')
+		.src('http://foo.com/test.js')
+		.dest(tempy.directory())
+		.use(process.platform === 'win32' ? 'gifsicle.exe' : 'gifsicle');
+
+	await bin.run();
+
+	const files = fs.readdirSync(bin.dest());
+
+	files.forEach(fileName => {
+		t.true(executable.sync(path.join(bin.dest(), fileName)));
+	});
+});