From 3382571ba71b38ea51a6eb105001752fab03e67c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javier=20Sua=CC=81rez=20Ruiz?= Date: Sun, 3 Oct 2021 18:57:44 +0200 Subject: [PATCH 1/2] Convert Color properties into Brush properties --- .../Views/DataVisualizationGallery.xaml | 29 +++++++++++++++++-- src/TemplateUI/DataVisualization/AreaChart.cs | 10 +++---- src/TemplateUI/DataVisualization/BarChart.cs | 10 +++---- .../DataVisualization/Base/SerialChart.cs | 22 +++++++------- src/TemplateUI/DataVisualization/LineChart.cs | 6 ++-- 5 files changed, 50 insertions(+), 27 deletions(-) diff --git a/src/TemplateUI.Gallery/Views/DataVisualizationGallery.xaml b/src/TemplateUI.Gallery/Views/DataVisualizationGallery.xaml index 6568642..36aa4cb 100644 --- a/src/TemplateUI.Gallery/Views/DataVisualizationGallery.xaml +++ b/src/TemplateUI.Gallery/Views/DataVisualizationGallery.xaml @@ -7,6 +7,29 @@ BarBackgroundColor="{StaticResource NavBarBackgroundColor}" BarTextColor="White" Title="DataVisualization Gallery"> + + + + + + + + + + + + @@ -27,7 +50,7 @@ @@ -40,7 +63,7 @@ diff --git a/src/TemplateUI/DataVisualization/AreaChart.cs b/src/TemplateUI/DataVisualization/AreaChart.cs index ccc10c4..29082d8 100644 --- a/src/TemplateUI/DataVisualization/AreaChart.cs +++ b/src/TemplateUI/DataVisualization/AreaChart.cs @@ -97,8 +97,8 @@ void InitializeAreaChart() _areaChart = new Polygon { Aspect = Stretch.Fill, - Fill = new SolidColorBrush(Color), - Stroke = new SolidColorBrush(Color), + Fill = Brush, + Stroke = Brush, StrokeThickness = 2 }; } @@ -117,10 +117,10 @@ public override void UpdateDataSource() UpdateCategoryData(); } - public override void UpdateColor() + public override void UpdateBrush() { - _areaChart.Stroke = new SolidColorBrush(Color); - _areaChart.Fill = new SolidColorBrush(Color); + _areaChart.Stroke = Brush; + _areaChart.Fill = Brush; } void UpdateValueData() diff --git a/src/TemplateUI/DataVisualization/BarChart.cs b/src/TemplateUI/DataVisualization/BarChart.cs index 4aa7c0f..25c57f6 100644 --- a/src/TemplateUI/DataVisualization/BarChart.cs +++ b/src/TemplateUI/DataVisualization/BarChart.cs @@ -111,8 +111,8 @@ void InitializeBarChart() _barChart = new Path { Aspect = Stretch.Fill, - Stroke = new SolidColorBrush(Color), - Fill = new SolidColorBrush(Color), + Stroke = Brush, + Fill = Brush, StrokeThickness = 1, Margin = new Thickness(24, 0) }; @@ -134,10 +134,10 @@ public override void UpdateDataSource() UpdateCategoryData(); } - public override void UpdateColor() + public override void UpdateBrush() { - _barChart.Stroke = new SolidColorBrush(Color); - _barChart.Fill = new SolidColorBrush(Color); + _barChart.Stroke = Brush; + _barChart.Fill = Brush; } void UpdateValueData() diff --git a/src/TemplateUI/DataVisualization/Base/SerialChart.cs b/src/TemplateUI/DataVisualization/Base/SerialChart.cs index dc89343..b26eaa0 100644 --- a/src/TemplateUI/DataVisualization/Base/SerialChart.cs +++ b/src/TemplateUI/DataVisualization/Base/SerialChart.cs @@ -77,20 +77,20 @@ public Color AxisColor set { SetValue(AxisColorProperty, value); } } - public static readonly BindableProperty ColorProperty = - BindableProperty.Create(nameof(Color), typeof(Color), typeof(SerialChart), Color.Black, - propertyChanged: OnColorPropertyChanged); + public static readonly BindableProperty BrushProperty = + BindableProperty.Create(nameof(Brush), typeof(Brush), typeof(SerialChart), new SolidColorBrush(Color.Black), + propertyChanged: OnBrushPropertyChanged); - static void OnColorPropertyChanged(BindableObject bindable, object oldValue, object newValue) + static void OnBrushPropertyChanged(BindableObject bindable, object oldValue, object newValue) { SerialChart chart = bindable as SerialChart; - chart.NotifyColorChanges(); + chart.NotifyBrushChanges(); } - public Color Color + public Brush Brush { - get { return (Color)GetValue(ColorProperty); } - set { SetValue(ColorProperty, value); } + get { return (Brush)GetValue(BrushProperty); } + set { SetValue(BrushProperty, value); } } public virtual void UpdateDataSource() @@ -98,7 +98,7 @@ public virtual void UpdateDataSource() } - public virtual void UpdateColor() + public virtual void UpdateBrush() { } @@ -108,9 +108,9 @@ void NotifyDataSourceChanges() UpdateDataSource(); } - void NotifyColorChanges() + void NotifyBrushChanges() { - UpdateColor(); + UpdateBrush(); } } } \ No newline at end of file diff --git a/src/TemplateUI/DataVisualization/LineChart.cs b/src/TemplateUI/DataVisualization/LineChart.cs index e25d7a1..1d81c0f 100644 --- a/src/TemplateUI/DataVisualization/LineChart.cs +++ b/src/TemplateUI/DataVisualization/LineChart.cs @@ -98,7 +98,7 @@ void InitializeLineChart() { Aspect = Stretch.Fill, WidthRequest = 100, - Stroke = new SolidColorBrush(Color), + Stroke = Brush, StrokeThickness = 2 }; } @@ -117,9 +117,9 @@ public override void UpdateDataSource() UpdateCategoryData(); } - public override void UpdateColor() + public override void UpdateBrush() { - _lineChart.Stroke = new SolidColorBrush(Color); + _lineChart.Stroke = Brush; } void UpdateValueData() From ecaf92f31341b1367806950161d997984d14b2fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javier=20Sua=CC=81rez=20Ruiz?= Date: Sun, 3 Oct 2021 19:14:20 +0200 Subject: [PATCH 2/2] Add brushes support in AvatarView --- .../Views/AvatarViewGallery.xaml | 75 ++++++++++++------- .../Controls/AvatarView/AvatarView.cs | 20 ++--- src/TemplateUI/Themes/Styles/AvatarView.xaml | 8 +- 3 files changed, 63 insertions(+), 40 deletions(-) diff --git a/src/TemplateUI.Gallery/Views/AvatarViewGallery.xaml b/src/TemplateUI.Gallery/Views/AvatarViewGallery.xaml index f193c80..848a93e 100644 --- a/src/TemplateUI.Gallery/Views/AvatarViewGallery.xaml +++ b/src/TemplateUI.Gallery/Views/AvatarViewGallery.xaml @@ -7,6 +7,29 @@ BarBackgroundColor="{StaticResource NavBarBackgroundColor}" BarTextColor="White" Title="AvatarView Gallery"> + + + + + + + + + + + + @@ -16,29 +39,29 @@ + BorderBrush="Black" + Background="Red"/> @@ -63,7 +86,7 @@ @@ -74,7 +97,7 @@ Grid.Column="1"> @@ -84,7 +107,7 @@ @@ -96,7 +119,7 @@ Grid.Row="1"> @@ -106,7 +129,7 @@ @@ -118,7 +141,7 @@ Grid.Row="2"> @@ -128,7 +151,7 @@ @@ -140,7 +163,7 @@ Grid.Row="3"> @@ -150,7 +173,7 @@ @@ -162,7 +185,7 @@ Grid.Row="4"> @@ -190,8 +213,8 @@