Skip to content

Commit a1532d3

Browse files
committed
fix: improve robustness across features
- pnp.powershell: add set -e so Install-Module failures abort the script (1.0.0 -> 1.0.1) - powershell-extended: fix typo 'validaiton' -> 'validation' in lib.sh warning message (2.1.1 -> 2.1.2)
1 parent 7c9c0c6 commit a1532d3

4 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/pnp.powershell/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "PnP PowerShell",
33
"id": "pnp.powershell",
4-
"version": "1.0.0",
4+
"version": "1.0.1",
55
"description": "PnP PowerShell is a cross-platform PowerShell module that allows users on any platform to manage various configuration settings of Microsoft 365.",
66
"documentationURL": "https://github.com/jpawlowski/devcontainer-features/tree/main/src/pnp.powershell",
77
"licenseURL": "https://github.com/jpawlowski/devcontainer-features/tree/main/LICENSE.txt",

src/pnp.powershell/install.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/bin/bash
2+
set -e
23

34
PSPNP_VERSION="${VERSION:-"latest"}"
45

src/powershell-extended/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"legacyIds": [
55
"powershell"
66
],
7-
"version": "2.1.1",
7+
"version": "2.1.2",
88
"description": "Installs PowerShell on AMD64 and ARM64 architectures, with optional resources from the PowerShell Gallery via PSResourceGet. Includes a custom Oh My Posh terminal prompt theme and customizable profile files. Supports advanced installation options for PowerShell modules and scripts.",
99
"documentationURL": "https://github.com/jpawlowski/devcontainer-features/tree/main/src/powershell-extended",
1010
"licenseURL": "https://github.com/jpawlowski/devcontainer-features/tree/main/LICENSE.txt",

src/powershell-extended/lib.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ function install_using_github() {
213213
curl -sSL -o "release.html" "https://github.com/PowerShell/PowerShell/releases/tag/v${POWERSHELL_VERSION}"
214214
powershell_archive_sha256="$(tr '\n' ' ' < release.html | sed 's|<[^>]*>||g' | grep -oP "${powershell_filename}\s+\K[0-9a-fA-F]{64}" || echo '')"
215215
if [ -z "${powershell_archive_sha256}" ]; then
216-
echo "(!) WARNING: Failed to retrieve SHA256 for archive. Skipping validaiton."
216+
echo "(!) WARNING: Failed to retrieve SHA256 for archive. Skipping validation."
217217
else
218218
echo "SHA256: ${powershell_archive_sha256}"
219219
echo "${powershell_archive_sha256} *${powershell_filename}" | sha256sum -c -

0 commit comments

Comments
 (0)