fix(template-no-aria-label-misuse): use strict equality for null/undefined check (self-lint)

johanrd · johanrd · commit facd88d34bab · 2026-04-26T10:12:16.000+02:00
diff --git a/lib/rules/template-no-aria-label-misuse.js b/lib/rules/template-no-aria-label-misuse.js
@@ -133,7 +133,7 @@ function hasNonEmptyLabelAttr(node, name) {
   // A valueless attribute (e.g. `<div aria-label>`) carries no accessible
   // name. Treat it as empty — not as non-empty — so downstream checks don't
   // mistake it for an author-declared label.
-  if (attr.value == null) {
+  if (attr.value === null || attr.value === undefined) {
     return false;
   }
   if (attr.value.type === 'GlimmerTextNode') {

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ function hasNonEmptyLabelAttr(node, name) {`
`133`	`133`	// A valueless attribute (e.g. `<div aria-label>`) carries no accessible
`134`	`134`	`// name. Treat it as empty — not as non-empty — so downstream checks don't`
`135`	`135`	`// mistake it for an author-declared label.`
`136`		`- if (attr.value == null) {`
	`136`	`+ if (attr.value === null \|\| attr.value === undefined) {`
`137`	`137`	`return false;`
`138`	`138`	`}`
`139`	`139`	`if (attr.value.type === 'GlimmerTextNode') {`