perf: pre-index interactive element schemas by tag name at module load

Author: johanrd

lib/rules/template-no-interactive-element-to-noninteractive-role.js

@@ -38,17 +38,24 @@ const { isNativeElement } = require('../utils/is-native-element');
 
 const interactiveRoleSet = INTERACTIVE_ROLES;
 
-const elementRoleEntries = [...elementRoles];
-
-// Schemas (element name + attribute constraints) whose role list contains at
-// least one interactive role.
-const interactiveElementRoleSchemas = elementRoleEntries
-  .filter(([, rolesArr]) => [...rolesArr].some((r) => interactiveRoleSet.has(r)))
-  .map(([schema]) => schema);
+// Pre-index interactive element schemas by tag name at module load. aria-query's
+// elementRoles is static data; bucketing by tag turns the per-node O(N) scan
+// over all schemas into a direct O(1) Map lookup followed by checking only the
+// 1–5 schemas for that specific tag.
+const INTERACTIVE_SCHEMAS_BY_TAG = (() => {
+  const index = new Map();
+  for (const [schema, rolesArr] of elementRoles) {
+    if ([...rolesArr].some((r) => interactiveRoleSet.has(r))) {
+      if (!index.has(schema.name)) {
+        index.set(schema.name, []);
+      }
+      index.get(schema.name).push(schema);
+    }
+  }
+  return index;
+})();
 
-const tagsWithInteractiveElementRoleEntry = new Set(
-  interactiveElementRoleSchemas.map((schema) => schema.name)
-);
+const tagsWithInteractiveElementRoleEntry = new Set(INTERACTIVE_SCHEMAS_BY_TAG.keys());
 
 // AX-fallback tag set — tags whose AXObject list is entirely widget AND which
 // have no interactive `elementRoles` entry. Excludes `canvas` per rationale
@@ -162,10 +169,7 @@ function isInteractiveElement(node) {
 
   // Primary signal: elementRoles with at least one interactive role + schema
   // constraints match the node's attributes.
-  for (const schema of interactiveElementRoleSchemas) {
-    if (schema.name !== tag) {
-      continue;
-    }
+  for (const schema of INTERACTIVE_SCHEMAS_BY_TAG.get(tag) ?? []) {
     if (!attributesMatchSchema(schema, node)) {
       continue;
     }