Commit ce6e2dd
committed
fix(#22): drop details/option/datalist from focusable set (Copilot review)
Per HTML §6.6.3 'Sequential focus navigation', none of <details>,
<option>, or <datalist> are focusable by default:
- <details>: the focusable control is its <summary> child
- <option>: not in default tab order; <select> is focused and arrow keys
navigate options within it
- <datalist>: no user-facing UI; the paired <input list> is focused
Including them in UNCONDITIONAL_FOCUSABLE_TAGS was over-aggressive and
caused false positives on this rule. Tests updated to pin the
now-allowed cases.1 parent 32a0eec commit ce6e2dd
2 files changed
Lines changed: 16 additions & 8 deletions
File tree
- lib/rules
- tests/lib/rules
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
62 | 68 | | |
63 | 69 | | |
64 | 70 | | |
65 | 71 | | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | 75 | | |
73 | 76 | | |
74 | 77 | | |
| |||
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
58 | 68 | | |
59 | 69 | | |
60 | 70 | | |
| |||
161 | 171 | | |
162 | 172 | | |
163 | 173 | | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | 174 | | |
170 | 175 | | |
171 | 176 | | |
| |||
0 commit comments