Skip to content

Commit c6e975c

Browse files
committed
fix(#57): address round-2 Copilot review (doc + test polish)
1 parent f8ac543 commit c6e975c

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

docs/rules/template-require-iframe-title.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ This rule **forbids** the following:
3232
<iframe title=' ' />
3333
<iframe title={{null}} />
3434
<iframe title={{undefined}} />
35+
<iframe title={{true}} />
36+
<iframe title={{false}} />
3537
<iframe title={{42}} />
3638
</template>
3739
```

lib/rules/template-require-iframe-title.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ module.exports = {
6565
missingTitle: '<iframe> elements must have a unique title property.',
6666
emptyTitle: '<iframe> elements must have a unique title property.',
6767
invalidTitleLiteral:
68-
'<iframe title> must be a non-empty string. Got a {{literalType}} literal, which does not describe the frame contents.',
68+
'<iframe title> must be a non-empty string. Got {{literalType}} literal, which does not describe the frame contents.',
6969
duplicateTitleFirst: 'This title is not unique. #{{index}}',
7070
duplicateTitleOther:
7171
'<iframe> elements must have a unique title property. Value title="{{title}}" already used for different iframe. #{{index}}',

tests/lib/rules/template-require-iframe-title.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ hbsRuleTester.run('template-require-iframe-title', rule, {
232232
errors: [
233233
{
234234
message:
235-
'<iframe title> must be a non-empty string. Got a boolean literal, which does not describe the frame contents.',
235+
'<iframe title> must be a non-empty string. Got boolean literal, which does not describe the frame contents.',
236236
},
237237
],
238238
},
@@ -242,7 +242,7 @@ hbsRuleTester.run('template-require-iframe-title', rule, {
242242
errors: [
243243
{
244244
message:
245-
'<iframe title> must be a non-empty string. Got a boolean literal, which does not describe the frame contents.',
245+
'<iframe title> must be a non-empty string. Got boolean literal, which does not describe the frame contents.',
246246
},
247247
],
248248
},
@@ -260,7 +260,7 @@ hbsRuleTester.run('template-require-iframe-title', rule, {
260260
errors: [
261261
{
262262
message:
263-
'<iframe title> must be a non-empty string. Got a boolean literal, which does not describe the frame contents.',
263+
'<iframe title> must be a non-empty string. Got boolean literal, which does not describe the frame contents.',
264264
},
265265
],
266266
},
@@ -270,7 +270,7 @@ hbsRuleTester.run('template-require-iframe-title', rule, {
270270
errors: [
271271
{
272272
message:
273-
'<iframe title> must be a non-empty string. Got a null literal, which does not describe the frame contents.',
273+
'<iframe title> must be a non-empty string. Got null literal, which does not describe the frame contents.',
274274
},
275275
],
276276
},
@@ -280,7 +280,7 @@ hbsRuleTester.run('template-require-iframe-title', rule, {
280280
errors: [
281281
{
282282
message:
283-
'<iframe title> must be a non-empty string. Got a undefined literal, which does not describe the frame contents.',
283+
'<iframe title> must be a non-empty string. Got undefined literal, which does not describe the frame contents.',
284284
},
285285
],
286286
},
@@ -290,7 +290,7 @@ hbsRuleTester.run('template-require-iframe-title', rule, {
290290
errors: [
291291
{
292292
message:
293-
'<iframe title> must be a non-empty string. Got a number literal, which does not describe the frame contents.',
293+
'<iframe title> must be a non-empty string. Got number literal, which does not describe the frame contents.',
294294
},
295295
],
296296
},

0 commit comments

Comments
 (0)