fix: unwrap mustache string literals in type attribute check

Author: johanrd

lib/rules/template-no-aria-hidden-on-focusable.js

@@ -1,17 +1,20 @@
 'use strict';
 
 const { isNativeElement } = require('../utils/is-native-element');
+const { getStaticAttrValue } = require('../utils/static-attr-value');
 
 function findAttr(node, name) {
   return node.attributes?.find((a) => a.name === name);
 }
 
+// Returns the statically-known string value of a named attribute, or
+// `undefined` when the attribute is absent or its value is dynamic.
 function getTextAttrValue(node, name) {
   const attr = findAttr(node, name);
-  if (attr?.value?.type === 'GlimmerTextNode') {
-    return attr.value.chars;
+  if (!attr) {
+    return undefined;
   }
-  return undefined;
+  return getStaticAttrValue(attr.value);
 }
 
 // Per WAI-ARIA 1.2 §6.6 + aria-hidden value table, a missing or empty-string

tests/lib/rules/template-no-aria-hidden-on-focusable.js

@@ -31,6 +31,8 @@ ruleTester.run('template-no-aria-hidden-on-focusable', rule, {
 
     // <input type="hidden"> isn't focusable, so aria-hidden on it is fine.
     '<template><input type="hidden" aria-hidden="true" /></template>',
+    // Mustache string literal — statically resolvable to "hidden".
+    '<template><input type={{"hidden"}} aria-hidden="true" /></template>',
 
     // <a> without href isn't focusable by default.
     '<template><a aria-hidden="true">Not a link</a></template>',
@@ -204,6 +206,8 @@ hbsRuleTester.run('template-no-aria-hidden-on-focusable', rule, {
     '<div aria-hidden="true"></div>',
     '<button>Click me</button>',
     '<input type="hidden" aria-hidden="true" />',
+    // Mustache string literal — statically resolvable to "hidden".
+    '<input type={{"hidden"}} aria-hidden="true" />',
     '<CustomBtn aria-hidden="true" />',
     // Descendant-focusable — non-focusable child.
     '<div aria-hidden="true"><span>Just text</span></div>',