Skip to content

Commit 784ca12

Browse files
committed
chore: drop temporal 'Previously was FP' comment
1 parent 4d28308 commit 784ca12

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

tests/audit/no-noninteractive-tabindex/peer-parity.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,6 @@ ruleTester.run('audit:no-noninteractive-tabindex (gts)', rule, {
6969
// `article`) are correctly skipped by `isComponentInvocation`, which
7070
// classifies the invocation BEFORE the `dom.has(tag)` check. Parity with
7171
// jsx-a11y's no-settings default (opaque component skip).
72-
//
73-
// Previously this was a FALSE POSITIVE (audit B8): `<Article tabindex={{0}} />`
74-
// was flagged because the rule lowercased `node.tag` before the
75-
// `dom.has(tag)` check, matching `article` in the dom map and validating
76-
// the component like the native tag. Adopting `isComponentInvocation`
77-
// fixes the FP.
7872
'<template><Article tabindex="-1" /></template>',
7973
'<template><Article tabindex={{0}} /></template>',
8074

tests/lib/rules/template-no-noninteractive-tabindex.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,8 @@ ruleTester.run('template-no-noninteractive-tabindex', rule, {
3838
'<template><my-widget tabindex="0"></my-widget></template>',
3939

4040
// PascalCase component whose name lowercases to a native tag — rule skips.
41-
// Before adopting isComponentInvocation, `<Article>` collided with
42-
// `article` in aria-query's dom map and produced a false positive
43-
// (audit B8). isComponentInvocation correctly classifies it as a
44-
// component invocation before the dom-map check.
41+
// `isComponentInvocation` classifies the invocation before the dom-map
42+
// check, so `<Article>` is not validated like the native `<article>` tag.
4543
'<template><Article tabindex={{0}} /></template>',
4644
'<template><Article tabindex="0" /></template>',
4745
'<template><Form tabindex={{0}} /></template>',

0 commit comments

Comments
 (0)