Merge pull request ember-cli#2660 from johanrd/night_fix/template-no-invalid-aria-attributes

Post-merge-review: Fix `template-no-invalid-aria-attributes`: reject boolean strings for string-typed ARIA attributes

Author: NullVoxPopuli

lib/rules/template-no-invalid-aria-attributes.js

@@ -28,9 +28,7 @@ function isValidAriaValue(attrName, value) {
     case 'tristate': {
       return isBoolean(value) || value === 'mixed';
     }
-    case 'string': {
-      return typeof value === 'string';
-    }
+    case 'string':
     case 'id': {
       return typeof value === 'string' && !isBoolean(value);
     }

tests/lib/rules/template-no-invalid-aria-attributes.js

@@ -116,6 +116,11 @@ ruleTester.run('template-no-invalid-aria-attributes', rule, {
       output: null,
       errors: [{ messageId: 'invalidAriaAttributeValue' }],
     },
+    {
+      code: '<template><div aria-label="true"></div></template>',
+      output: null,
+      errors: [{ messageId: 'invalidAriaAttributeValue' }],
+    },
   ],
 });