fix: normalize <input type>, plumb ignoreUsemap, align contenteditable empty-string (Copilot review)

Author: johanrd

lib/rules/template-no-invalid-interactive.js

@@ -87,7 +87,7 @@ module.exports = {
       // HTML §3.2.5.2.7 interactive content (authoritative for content-model;
       // handles label/button/etc. + conditional a[href], input[!hidden],
       // img[usemap], audio/video[controls]).
-      if (isHtmlInteractiveContent(node, getTextAttr)) {
+      if (isHtmlInteractiveContent(node, getTextAttr, { ignoreUsemap })) {
         return true;
       }
 
@@ -109,10 +109,15 @@ module.exports = {
         return true;
       }
 
-      // Check contenteditable
-      const ce = getTextAttr(node, 'contenteditable');
-      if (ce && ce !== 'false') {
-        return true;
+      // Check contenteditable. Per HTML spec, valid keywords are "true",
+      // "false", "plaintext-only", and the empty string (which is the default
+      // state, equivalent to "true"). So the attribute enables editing unless
+      // its value is "false".
+      if (hasAttr(node, 'contenteditable')) {
+        const ce = getTextAttr(node, 'contenteditable');
+        if (ce === undefined || ce === null || ce.trim().toLowerCase() !== 'false') {
+          return true;
+        }
       }
 
       // Check usemap (only on img/object)

lib/rules/template-no-nested-interactive.js

@@ -139,10 +139,15 @@ module.exports = {
         return true;
       }
 
-      // Check contenteditable
-      const ce = getTextAttr(node, 'contenteditable');
-      if (ce && ce !== 'false') {
-        return true;
+      // Check contenteditable. Per HTML spec, valid keywords are "true",
+      // "false", "plaintext-only", and the empty string (which is the default
+      // state, equivalent to "true"). So the attribute enables editing unless
+      // its value is "false".
+      if (hasAttr(node, 'contenteditable')) {
+        const ce = getTextAttr(node, 'contenteditable');
+        if (ce === undefined || ce === null || ce.trim().toLowerCase() !== 'false') {
+          return true;
+        }
       }
 
       // <object usemap> — not in HTML §3.2.5.2.7 but upstream ember-template-lint
@@ -175,9 +180,11 @@ module.exports = {
       if (role && INTERACTIVE_ROLES.has(role)) {
         return false;
       }
-      const ce = getTextAttr(node, 'contenteditable');
-      if (ce && ce !== 'false') {
-        return false;
+      if (hasAttr(node, 'contenteditable')) {
+        const ce = getTextAttr(node, 'contenteditable');
+        if (ce === undefined || ce === null || ce.trim().toLowerCase() !== 'false') {
+          return false;
+        }
       }
       if ((tag === 'img' || tag === 'object') && hasAttr(node, 'usemap')) {
         return false;

lib/utils/html-interactive-content.js

@@ -63,7 +63,7 @@ function isHtmlInteractiveContent(node, getTextAttrValue, options = {}) {
   // input — interactive unless type="hidden"
   if (tag === 'input') {
     const type = getTextAttrValue(node, 'type');
-    return type !== 'hidden';
+    return type === undefined || type === null || type.trim().toLowerCase() !== 'hidden';
   }
 
   // a — interactive only when href is present

tests/lib/utils/html-interactive-content-test.js

@@ -53,6 +53,18 @@ describe('isHtmlInteractiveContent', () => {
         isHtmlInteractiveContent(makeNode('input', { type: 'hidden' }), getTextAttrValue)
       ).toBe(false);
     });
+
+    it('is NOT interactive when type="HIDDEN" (case-insensitive)', () => {
+      expect(
+        isHtmlInteractiveContent(makeNode('input', { type: 'HIDDEN' }), getTextAttrValue)
+      ).toBe(false);
+    });
+
+    it('is NOT interactive when type=" hidden " (whitespace-trimmed)', () => {
+      expect(
+        isHtmlInteractiveContent(makeNode('input', { type: ' hidden ' }), getTextAttrValue)
+      ).toBe(false);
+    });
   });
 
   describe('<a>', () => {