fix: skip dynamic roles, fix code formatting (Copilot review)

Author: johanrd

docs/rules/template-no-aria-label-misuse.md

@@ -39,9 +39,9 @@ the plugin's "when in doubt, don't flag" stance.
 ## Configuration
 
 - `strictTabindex` (`boolean`, default `false`): when `true`, the
-  tabindex escape hatch is disabled — a `<div tabindex="0"
-aria-label="x">` is flagged as strictly as any other generic element.
-  Enable this for strict spec-role enforcement.
+  tabindex escape hatch is disabled — a `<div tabindex="0" aria-label="x">`
+  is flagged as strictly as any other generic element. Enable this for
+  strict spec-role enforcement.
 
 ```js
 module.exports = {

lib/rules/template-no-aria-label-misuse.js

@@ -1,7 +1,7 @@
 // Logic inspired by html-validate (MIT), Copyright 2017 David Sveningsson.
 // Role resolution delegates to `aria-query` — the authoritative WAI-ARIA
-// data package (already a dependency of this plugin). `roles.get(r)
-// .prohibitedProps` drives the flag/allow decision.
+// data package (already a dependency of this plugin). The
+// `roles.get(r).prohibitedProps` list drives the flag/allow decision.
 
 const { roles, elementRoles } = require('aria-query');
 
@@ -79,12 +79,22 @@ function getImplicitRole(node) {
 }
 
 function getRole(node) {
-  const explicit = getStaticAttrString(node, 'role');
-  if (explicit) {
+  const roleAttr = findAttr(node, 'role');
+  if (roleAttr) {
+    // Present but dynamic (mustache / concat) — the runtime role is unknown,
+    // and if it differs from the element's implicit role we'd false-positive
+    // against the implicit. Skip rather than guess.
+    const explicit = getStaticAttrString(node, 'role');
+    if (explicit === null) {
+      return null;
+    }
     const first = explicit.trim().split(/\s+/)[0]?.toLowerCase();
     if (first && roles.has(first)) {
       return first;
     }
+    // `role` present with an unknown token (e.g. `role="bogus"`) — per ARIA
+    // the invalid value is ignored and the implicit role applies. Fall
+    // through to the implicit-role lookup.
   }
   return getImplicitRole(node);
 }

tests/lib/rules/template-no-aria-label-misuse.js

@@ -37,6 +37,10 @@ const validHbs = [
   '<section aria-label="About"></section>',
   // <form> transitions to role=form when aria-label is present.
   '<form aria-label="Search"></form>',
+  // Dynamic role — runtime role may differ from implicit; skip rather than
+  // false-flag against the element's implicit role.
+  '<div role={{this.role}} aria-label="x">x</div>',
+  '<span role={{this.role}} aria-labelledby="t">x</span>',
 ];
 
 const invalidHbs = [