fix: treat mustache empty strings as no accessible name; add aria-hidden string-literal tests

Author: johanrd

lib/rules/template-anchor-has-content.js

@@ -37,7 +37,22 @@ function hasAccessibleNameAttribute(node) {
     if (!attr) {
       continue;
     }
+    if (attr.value?.type === 'GlimmerMustacheStatement') {
+      const resolved = getStaticAttrValue(attr.value);
+      if (resolved === undefined) {
+        // Truly dynamic (e.g. `aria-label={{@label}}`) — can't know at lint
+        // time; give the author the benefit of the doubt.
+        return true;
+      }
+      // Static string literal in mustache, e.g. `aria-label={{""}}`.
+      // Treat exactly like a plain text value: non-empty means a name exists.
+      if (resolved.trim().length > 0) {
+        return true;
+      }
+      continue;
+    }
     if (isDynamicValue(attr.value)) {
+      // GlimmerConcatStatement — treat as dynamic.
       return true;
     }
     if (attr.value?.type === 'GlimmerTextNode') {
@@ -105,7 +120,18 @@ function evaluateChild(child, sourceCode) {
         // Missing alt is a separate a11y concern; treat as no contribution.
         return { dynamic: false, accessible: false };
       }
+      if (altAttr.value?.type === 'GlimmerMustacheStatement') {
+        const resolved = getStaticAttrValue(altAttr.value);
+        if (resolved === undefined) {
+          // Truly dynamic (e.g. `alt={{@alt}}`) — trust the author.
+          return { dynamic: true, accessible: false };
+        }
+        // Static string literal in mustache, e.g. `alt={{""}}` or
+        // `alt={{"Search"}}` — treat exactly like a plain text value.
+        return { dynamic: false, accessible: resolved.trim().length > 0 };
+      }
       if (isDynamicValue(altAttr.value)) {
+        // GlimmerConcatStatement — treat as dynamic.
         return { dynamic: true, accessible: false };
       }
       if (altAttr.value?.type === 'GlimmerTextNode') {

tests/lib/rules/template-anchor-has-content.js

@@ -46,6 +46,19 @@ ruleTester.run('template-anchor-has-content', rule, {
       code: '<template><a href="/x"><img alt={{@alt}} /></a></template>',
     },
 
+    // <img alt={{"…"}}> — static string in mustache; non-empty alt counts as
+    // accessible content.
+    {
+      filename: 'test.gjs',
+      code: '<template><a href="/x"><img alt={{"Search"}} /></a></template>',
+    },
+
+    // aria-label with a non-empty mustache string literal is a valid name.
+    {
+      filename: 'test.gjs',
+      code: '<template><a href="/x" aria-label={{"Close"}} /></template>',
+    },
+
     // Component invocation (PascalCase) — not a plain HTML anchor, out of scope.
     { filename: 'test.gjs', code: '<template><Link href="/x" /></template>' },
 
@@ -101,6 +114,12 @@ ruleTester.run('template-anchor-has-content', rule, {
       filename: 'test.gjs',
       code: '<template><a href="/x" aria-hidden={{true}}></a></template>',
     },
+    // aria-hidden={{"true"}} — string-literal mustache, resolved statically to
+    // "true"; anchor is hidden from the a11y tree, check does not apply.
+    {
+      filename: 'test.gjs',
+      code: '<template><a href="/x" aria-hidden={{"true"}} /></template>',
+    },
 
     // Scope-shadowed lowercase `a` (local binding in GJS) — not the native
     // HTML anchor, so the rule does not validate it. `isNativeElement`
@@ -185,6 +204,21 @@ ruleTester.run('template-anchor-has-content', rule, {
       output: null,
       errors: [{ messageId: 'anchorHasContent' }],
     },
+    // aria-label={{""}} — static empty string in mustache is NOT a name.
+    {
+      filename: 'test.gjs',
+      code: '<template><a href="/x" aria-label={{""}} /></template>',
+      output: null,
+      errors: [{ messageId: 'anchorHasContent' }],
+    },
+    // <img alt={{""}}> — static empty string in mustache is decorative;
+    // no accessible name contributed.
+    {
+      filename: 'test.gjs',
+      code: '<template><a href="/x"><img alt={{""}} /></a></template>',
+      output: null,
+      errors: [{ messageId: 'anchorHasContent' }],
+    },
     // `&nbsp;` is normalized to space — `aria-label="&nbsp;"` is functionally
     // empty for assistive tech and should not count as an accessible name.
     {
@@ -222,6 +256,22 @@ ruleTester.run('template-anchor-has-content', rule, {
       output: null,
       errors: [{ messageId: 'anchorHasContent' }],
     },
+    // aria-hidden={{"false"}} — string-literal mustache resolves to "false";
+    // anchor is NOT hidden, so the content check applies and should flag.
+    {
+      filename: 'test.gjs',
+      code: '<template><a href="/x" aria-hidden={{"false"}} /></template>',
+      output: null,
+      errors: [{ messageId: 'anchorHasContent' }],
+    },
+    // aria-hidden={{"true"}} on a child — child is hidden, contributes nothing;
+    // the anchor itself is still in scope and has no accessible content.
+    {
+      filename: 'test.gjs',
+      code: '<template><a href="/x"><span aria-hidden={{"true"}}>X</span></a></template>',
+      output: null,
+      errors: [{ messageId: 'anchorHasContent' }],
+    },
   ],
 });