forked from ember-cli/eslint-plugin-ember
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathtemplate-no-empty-headings.js
More file actions
166 lines (152 loc) · 4.91 KB
/
template-no-empty-headings.js
File metadata and controls
166 lines (152 loc) · 4.91 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
const HEADINGS = new Set(['h1', 'h2', 'h3', 'h4', 'h5', 'h6']);
// aria-hidden semantics for valueless / empty / "false" are genuinely
// contested — four ecosystem positions exist (jsx-a11y / vue-a11y / axe /
// WAI-ARIA spec), see PR body. This rule leans toward FEWER false positives:
// when the author has written `aria-hidden` in any form that could plausibly
// mean "hide this", we exempt the heading from the empty-content check. The
// downside (missing some genuinely-empty headings) is preferable to flagging
// correctly-authored headings the developer intentionally decorated.
//
// Truthy:
// - valueless attr (`<h1 aria-hidden>`) — default-undefined per spec, but
// authors who write bare `aria-hidden` plausibly intend hidden.
// - empty string `aria-hidden=""` — same.
// - `aria-hidden="true"` / "TRUE" / "True" (ASCII case-insensitive).
// - `aria-hidden={{true}}` mustache boolean literal.
// - `aria-hidden={{"true"}}` / case-variants as mustache string literal.
// Not truthy (falls through):
// - `aria-hidden="false"` / `{{false}}` / `{{"false"}}` — explicit opt-out.
function isAriaHiddenTruthy(attr) {
if (!attr) {
return false;
}
const value = attr.value;
// Valueless attribute — no `value` property at all.
if (!value) {
return true;
}
if (value.type === 'GlimmerTextNode') {
const chars = value.chars.toLowerCase();
// Empty string is exempted (lean toward fewer false positives).
return chars === '' || chars === 'true';
}
if (value.type === 'GlimmerMustacheStatement' && value.path) {
if (value.path.type === 'GlimmerBooleanLiteral') {
return value.path.value === true;
}
if (value.path.type === 'GlimmerStringLiteral') {
return value.path.value.toLowerCase() === 'true';
}
}
return false;
}
function isHidden(node) {
if (!node.attributes) {
return false;
}
if (node.attributes.some((a) => a.name === 'hidden')) {
return true;
}
return isAriaHiddenTruthy(node.attributes.find((a) => a.name === 'aria-hidden'));
}
function isComponent(node) {
if (node.type !== 'GlimmerElementNode') {
return false;
}
const tag = node.tag;
// PascalCase (<MyComponent>), namespaced (<Foo::Bar>), this.-prefixed
// (<this.Component>), arg-prefixed (<@component>), or dot-path (<ns.Widget>)
return (
/^[A-Z]/.test(tag) ||
tag.includes('::') ||
tag.startsWith('this.') ||
tag.startsWith('@') ||
tag.includes('.')
);
}
function isTextEmpty(text) {
// Treat (U+00A0) and regular whitespace as empty
return text.replaceAll(/\s/g, '').replaceAll(' ', '').length === 0;
}
function hasAccessibleContent(node) {
if (!node.children || node.children.length === 0) {
return false;
}
for (const child of node.children) {
// Text nodes — only counts if it has real visible characters
if (child.type === 'GlimmerTextNode') {
if (!isTextEmpty(child.chars)) {
return true;
}
continue;
}
// Mustache/block statements are dynamic content
if (child.type === 'GlimmerMustacheStatement' || child.type === 'GlimmerBlockStatement') {
return true;
}
// Element nodes
if (child.type === 'GlimmerElementNode') {
// Skip hidden elements entirely
if (isHidden(child)) {
continue;
}
// Component invocations count as content (they may render text)
if (isComponent(child)) {
return true;
}
// Recurse into non-hidden, non-component elements
if (hasAccessibleContent(child)) {
return true;
}
}
}
return false;
}
function isHeadingElement(node) {
if (HEADINGS.has(node.tag)) {
return true;
}
// Also detect <div role="heading" ...>
const roleAttr = node.attributes?.find((a) => a.name === 'role');
if (roleAttr?.value?.type === 'GlimmerTextNode' && roleAttr.value.chars === 'heading') {
return true;
}
return false;
}
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
meta: {
type: 'problem',
docs: {
description: 'disallow empty heading elements',
category: 'Accessibility',
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-empty-headings.md',
},
schema: [],
messages: {
emptyHeading:
'Headings must contain accessible text content (or helper/component that provides text).',
},
originallyFrom: {
name: 'ember-template-lint',
rule: 'lib/rules/no-empty-headings.js',
docs: 'docs/rule/no-empty-headings.md',
tests: 'test/unit/rules/no-empty-headings-test.js',
},
},
create(context) {
return {
GlimmerElementNode(node) {
if (isHeadingElement(node)) {
// Skip if the heading itself is hidden
if (isHidden(node)) {
return;
}
if (!hasAccessibleContent(node)) {
context.report({ node, messageId: 'emptyHeading' });
}
}
},
};
},
};