From 383ccad5704878b45e0ce3097f1edbbe55c063ba Mon Sep 17 00:00:00 2001
From: nate1729 <nferreira1729@gmail.com>
Date: Tue, 17 Feb 2026 17:07:14 -0500
Subject: [PATCH] fix: fix typing bugs

dataclasses are not the same as dictionaries.
---
 .../calculations/capability_calculations.py               | 4 ++--
 .../calculations/loss_function_calculations.py            | 8 ++++----
 process_improvement/calculations/xmr_calculations.py      | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/process_improvement/calculations/capability_calculations.py b/process_improvement/calculations/capability_calculations.py
index 0b7b1c6..ccd83d4 100644
--- a/process_improvement/calculations/capability_calculations.py
+++ b/process_improvement/calculations/capability_calculations.py
@@ -13,7 +13,7 @@ def calculate_capability_indices(
         LSL: int,
         Target: int,
         round_value: int = 2,
-        ) -> dict[str, float]:
+        ) -> ProcessCapabilityIndices:
         """
         Calculate process capability and performance indices.
 
@@ -142,4 +142,4 @@ def calculate_capability_indices(
             mean=mean,
             s=s, # The standard deviation
             average_mR=ave_mR,
-        )
\ No newline at end of file
+        )
diff --git a/process_improvement/calculations/loss_function_calculations.py b/process_improvement/calculations/loss_function_calculations.py
index d3c4cde..028d08a 100644
--- a/process_improvement/calculations/loss_function_calculations.py
+++ b/process_improvement/calculations/loss_function_calculations.py
@@ -12,7 +12,7 @@ def taguchi_loss_calcs(
         USL: float,
         LSL: float,
         Target: Optional[float] = None
-        ) -> dict[str, float or list]:
+        ) -> TaguchiLossCalcResults:
     """
     Compute quadratic loss function (Taguchi loss function) values over a
     specification range.
@@ -117,9 +117,9 @@ def expected_loss_calc(
         USL: float,
         LSL: float,
         Target: Optional[float] = None,
-        cost_of_scrap: Optional[float] = 1,
+        cost_of_scrap: float = 1,
         # round_value: Optional[float] = 1
-        ) -> dict[str, float or list]:
+        ) -> ExpectedLossCalcResults:
     """
     Docstring for expected_loss
 
@@ -157,4 +157,4 @@ def expected_loss_calc(
 
     return ExpectedLossCalcResults(
         df=stats_df
-    )
\ No newline at end of file
+    )
diff --git a/process_improvement/calculations/xmr_calculations.py b/process_improvement/calculations/xmr_calculations.py
index 9d242e5..5d568d4 100644
--- a/process_improvement/calculations/xmr_calculations.py
+++ b/process_improvement/calculations/xmr_calculations.py
@@ -43,7 +43,7 @@ def calculate_xmr_limits(
             restrict_LPL: bool,
             max_value: float = 100.0,
             min_value: float = 0.0
-            ) -> dict[str, float]:
+            ) -> XmRLimits:
             """
             Calculate Individuals and Moving Range (XmR) process limits.
 
@@ -227,4 +227,4 @@ def characterize_mr_variation(
             ),
             index=mr.index,
             name="mR chart variation"
-        )
\ No newline at end of file
+        )