Fixup system properties

Author: timja

src/main/java/io/jenkins/plugins/pipelinegraphview/livestate/LiveGraphRegistry.java

@@ -3,6 +3,7 @@
 import com.github.benmanes.caffeine.cache.Cache;
 import com.github.benmanes.caffeine.cache.Caffeine;
 import java.time.Duration;
+import jenkins.util.SystemProperties;
 import org.jenkinsci.plugins.workflow.flow.FlowExecution;
 import org.jenkinsci.plugins.workflow.job.WorkflowRun;
 
@@ -20,26 +21,24 @@ public static LiveGraphRegistry get() {
         return INSTANCE;
     }
 
-    /**
-     * Escape hatch. Setting this system property to {@code false} makes
-     * {@link #snapshot(WorkflowRun)} always return {@code null}, forcing callers to use the
-     * scanner fallback. Useful if a regression lands in the live-state path.
-     */
-    private static final String ENABLED_PROPERTY = "pipelinegraphview.livestate.enabled";
-
     private final Cache<String, LiveGraphState> states = Caffeine.newBuilder()
             .maximumSize(256)
             .expireAfterAccess(Duration.ofMinutes(30))
             .build();
 
     LiveGraphRegistry() {}
 
-    private static boolean enabled() {
-        return !"false".equalsIgnoreCase(System.getProperty(ENABLED_PROPERTY));
+    /**
+     * Escape hatch. Setting this system property to {@code false} makes
+     * {@link #snapshot(WorkflowRun)} always return {@code null}, forcing callers to use the
+     * scanner fallback. Useful if a regression lands in the live-state path.
+     */
+    private static boolean disabled() {
+        return !SystemProperties.getBoolean(LiveGraphRegistry.class.getName() + ".enabled", true);
     }
 
     LiveGraphState getOrCreate(FlowExecution execution) {
-        if (!enabled()) {
+        if (disabled()) {
             return null;
         }
         String key = keyFor(execution);
@@ -49,21 +48,13 @@ LiveGraphState getOrCreate(FlowExecution execution) {
         return states.get(key, LiveGraphState::new);
     }
 
-    LiveGraphState get(FlowExecution execution) {
-        if (!enabled()) {
-            return null;
-        }
-        String key = keyFor(execution);
-        return key == null ? null : states.getIfPresent(key);
-    }
-
     /**
      * Returns a snapshot of the live state for this run, or {@code null} if none exists
      * (feature disabled, state never populated, state poisoned). Callers must treat
      * {@code null} as "fall back to the scanner path."
      */
     public LiveGraphSnapshot snapshot(WorkflowRun run) {
-        if (!enabled()) {
+        if (disabled()) {
             return null;
         }
         LiveGraphState state = states.getIfPresent(run.getExternalizableId());
@@ -77,11 +68,6 @@ void remove(FlowExecution execution) {
         }
     }
 
-    /** Test hook: drop all entries so a fresh Jenkins instance starts with a clean slate. */
-    void invalidateAll() {
-        states.invalidateAll();
-    }
-
     private static String keyFor(FlowExecution execution) {
         try {
             Object exec = execution.getOwner().getExecutable();