Skip to content

Commit e611986

Browse files
authored
Merge pull request #245 from basil/jakarta
Migrate from EE 8 to EE 9
2 parents d249529 + b8678a4 commit e611986

3 files changed

Lines changed: 40 additions & 28 deletions

File tree

pom.xml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>org.jenkins-ci.plugins</groupId>
77
<artifactId>plugin</artifactId>
8-
<version>4.86</version>
8+
<version>5.7</version>
99
<relativePath />
1010
</parent>
1111

@@ -16,7 +16,9 @@
1616
<properties>
1717
<changelist>999999-SNAPSHOT</changelist>
1818
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
19-
<jenkins.version>2.426.3</jenkins.version>
19+
<!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
20+
<jenkins.baseline>2.479</jenkins.baseline>
21+
<jenkins.version>${jenkins.baseline}.1</jenkins.version>
2022
</properties>
2123

2224
<name>Parameterized Scheduler</name>
@@ -90,8 +92,8 @@
9092
<dependencies>
9193
<dependency>
9294
<groupId>io.jenkins.tools.bom</groupId>
93-
<artifactId>bom-2.426.x</artifactId>
94-
<version>3208.vb_21177d4b_cd9</version>
95+
<artifactId>bom-${jenkins.baseline}.x</artifactId>
96+
<version>3850.vb_c5319efa_e29</version>
9597
<scope>import</scope>
9698
<type>pom</type>
9799
</dependency>

src/main/java/org/jenkinsci/plugins/parameterizedscheduler/ParameterizedStaplerRequest.java

Lines changed: 31 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
11
package org.jenkinsci.plugins.parameterizedscheduler;
22

33
import net.sf.json.JSONObject;
4-
import org.apache.commons.fileupload.FileItem;
4+
import org.apache.commons.fileupload2.core.FileItem;
55
import org.kohsuke.stapler.Ancestor;
66
import org.kohsuke.stapler.BindInterceptor;
77
import org.kohsuke.stapler.Stapler;
8-
import org.kohsuke.stapler.StaplerRequest;
9-
import org.kohsuke.stapler.StaplerResponse;
8+
import org.kohsuke.stapler.StaplerRequest2;
9+
import org.kohsuke.stapler.StaplerResponse2;
1010
import org.kohsuke.stapler.WebApp;
1111
import org.kohsuke.stapler.bind.BoundObjectTable;
1212
import org.kohsuke.stapler.lang.Klass;
1313

14-
import javax.servlet.AsyncContext;
15-
import javax.servlet.DispatcherType;
16-
import javax.servlet.RequestDispatcher;
17-
import javax.servlet.ServletContext;
18-
import javax.servlet.ServletInputStream;
19-
import javax.servlet.ServletRequest;
20-
import javax.servlet.ServletResponse;
21-
import javax.servlet.http.Cookie;
22-
import javax.servlet.http.HttpServletResponse;
23-
import javax.servlet.http.HttpSession;
24-
import javax.servlet.http.HttpUpgradeHandler;
25-
import javax.servlet.http.Part;
14+
import jakarta.servlet.AsyncContext;
15+
import jakarta.servlet.DispatcherType;
16+
import jakarta.servlet.RequestDispatcher;
17+
import jakarta.servlet.ServletContext;
18+
import jakarta.servlet.ServletInputStream;
19+
import jakarta.servlet.ServletRequest;
20+
import jakarta.servlet.ServletResponse;
21+
import jakarta.servlet.http.Cookie;
22+
import jakarta.servlet.http.HttpServletResponse;
23+
import jakarta.servlet.http.HttpSession;
24+
import jakarta.servlet.http.HttpUpgradeHandler;
25+
import jakarta.servlet.http.Part;
2626
import java.io.BufferedReader;
2727
import java.lang.reflect.Type;
2828
import java.security.Principal;
@@ -34,7 +34,7 @@
3434
import java.util.Locale;
3535
import java.util.Map;
3636

37-
public class ParameterizedStaplerRequest implements StaplerRequest {
37+
public class ParameterizedStaplerRequest implements StaplerRequest2 {
3838

3939
private final String value;
4040

@@ -481,22 +481,22 @@ public String getOriginalRequestURI() {
481481
}
482482

483483
@Override
484-
public boolean checkIfModified(long timestampOfResource, StaplerResponse rsp) {
484+
public boolean checkIfModified(long timestampOfResource, StaplerResponse2 rsp) {
485485
return false;
486486
}
487487

488488
@Override
489-
public boolean checkIfModified(Date timestampOfResource, StaplerResponse rsp) {
489+
public boolean checkIfModified(Date timestampOfResource, StaplerResponse2 rsp) {
490490
return false;
491491
}
492492

493493
@Override
494-
public boolean checkIfModified(Calendar timestampOfResource, StaplerResponse rsp) {
494+
public boolean checkIfModified(Calendar timestampOfResource, StaplerResponse2 rsp) {
495495
return false;
496496
}
497497

498498
@Override
499-
public boolean checkIfModified(long timestampOfResource, StaplerResponse rsp, long expiration) {
499+
public boolean checkIfModified(long timestampOfResource, StaplerResponse2 rsp, long expiration) {
500500
return false;
501501
}
502502

@@ -561,7 +561,12 @@ public JSONObject getSubmittedForm() {
561561
}
562562

563563
@Override
564-
public FileItem getFileItem(String name) {
564+
public FileItem getFileItem2(String name) {
565+
return null;
566+
}
567+
568+
@Override
569+
public org.apache.commons.fileupload.FileItem getFileItem(String name) {
565570
return null;
566571
}
567572

@@ -580,6 +585,11 @@ public String createJavaScriptProxy(Object toBeExported) {
580585
return null;
581586
}
582587

588+
@Override
589+
public RenderOnDemandParameters createJavaScriptProxyParameters(Object toBeExported) {
590+
return null;
591+
}
592+
583593
@Override
584594
public BindInterceptor setBindInterceptpr(BindInterceptor bindListener) {
585595
return null;

src/test/java/org/jenkinsci/plugins/parameterizedscheduler/ParameterizedSchedulerTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import org.junit.Test;
1919
import org.jvnet.hudson.test.Issue;
2020
import org.jvnet.hudson.test.JenkinsRule;
21-
import org.kohsuke.stapler.StaplerRequest;
21+
import org.kohsuke.stapler.StaplerRequest2;
2222

2323
import java.util.ArrayList;
2424
import java.util.List;
@@ -149,13 +149,13 @@ public NullParameterDefinition(@NonNull String name) {
149149

150150
@CheckForNull
151151
@Override
152-
public ParameterValue createValue(StaplerRequest staplerRequest, JSONObject jsonObject) {
152+
public ParameterValue createValue(StaplerRequest2 staplerRequest, JSONObject jsonObject) {
153153
return null;
154154
}
155155

156156
@CheckForNull
157157
@Override
158-
public ParameterValue createValue(StaplerRequest staplerRequest) {
158+
public ParameterValue createValue(StaplerRequest2 staplerRequest) {
159159
return null;
160160
}
161161
}

0 commit comments

Comments
 (0)