From cde830b9f85de1366dbb3494399a947043d4f83f Mon Sep 17 00:00:00 2001 From: somiljain2006 Date: Fri, 17 Apr 2026 22:44:30 +0530 Subject: [PATCH] Refactor GlobalConfigurationCategoryConfigurator to remove raw type cast in describe() --- .../GlobalConfigurationCategoryConfigurator.java | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/plugin/src/main/java/io/jenkins/plugins/casc/impl/configurators/GlobalConfigurationCategoryConfigurator.java b/plugin/src/main/java/io/jenkins/plugins/casc/impl/configurators/GlobalConfigurationCategoryConfigurator.java index 25224a4e06..1f67c430f5 100644 --- a/plugin/src/main/java/io/jenkins/plugins/casc/impl/configurators/GlobalConfigurationCategoryConfigurator.java +++ b/plugin/src/main/java/io/jenkins/plugins/casc/impl/configurators/GlobalConfigurationCategoryConfigurator.java @@ -80,19 +80,24 @@ protected GlobalConfigurationCategory instance(Mapping mapping, ConfigurationCon return category; } - @SuppressWarnings("RedundantCast") // TODO remove once we are on JDK 11 @NonNull @Override - public Set describe() { - return (Set) Jenkins.get().getExtensionList(Descriptor.class).stream() + public Set> describe() { + return Jenkins.get().getExtensionList(Descriptor.class).stream() .filter(d -> d.getCategory() == category) .filter(d -> d.getGlobalConfigPage() != null) .map(DescriptorConfigurator::new) .filter(GlobalConfigurationCategoryConfigurator::reportDescriptorWithoutSetters) - .map(c -> new Attribute(c.getNames(), c.getTarget()).setter(NOP)) + .map(c -> new Attribute(c.getNames(), c.getTarget()) + .setter(typedNop())) .collect(Collectors.toSet()); } + @SuppressWarnings("unchecked") + private static Attribute.Setter typedNop() { + return (Attribute.Setter) NOP; + } + public static boolean reportDescriptorWithoutSetters(Configurator c) { if (c.describe().isEmpty()) { LOGGER.fine(