Skip to content

Commit f551dc2

Browse files
committed
Remove duplicate set_vt
1 parent f7bb4de commit f551dc2

2 files changed

Lines changed: 6 additions & 80 deletions

File tree

pgmq_sqlalchemy/queue.py

Lines changed: 0 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -1366,67 +1366,6 @@ def metrics_all(self) -> Optional[List[QueueMetrics]]:
13661366
return self.loop.run_until_complete(self._metrics_all_async())
13671367
return self._metrics_all_sync()
13681368

1369-
def _set_vt_sync(self, queue_name: str, msg_id: int, vt: int) -> Optional[Message]:
1370-
"""Set the visibility timeout of a message synchronously."""
1371-
with self.session_maker() as session:
1372-
row = session.execute(
1373-
text("select * from pgmq.set_vt(:queue_name, :msg_id, :vt);"),
1374-
{"queue_name": queue_name, "msg_id": msg_id, "vt": vt},
1375-
).fetchone()
1376-
session.commit()
1377-
if row is None:
1378-
return None
1379-
return Message(
1380-
msg_id=row[0], read_ct=row[1], enqueued_at=row[2], vt=row[3], message=row[4]
1381-
)
1382-
1383-
async def _set_vt_async(
1384-
self, queue_name: str, msg_id: int, vt: int
1385-
) -> Optional[Message]:
1386-
"""Set the visibility timeout of a message asynchronously."""
1387-
async with self.session_maker() as session:
1388-
row = (
1389-
await session.execute(
1390-
text("select * from pgmq.set_vt(:queue_name, :msg_id, :vt);"),
1391-
{"queue_name": queue_name, "msg_id": msg_id, "vt": vt},
1392-
)
1393-
).fetchone()
1394-
await session.commit()
1395-
if row is None:
1396-
return None
1397-
return Message(
1398-
msg_id=row[0], read_ct=row[1], enqueued_at=row[2], vt=row[3], message=row[4]
1399-
)
1400-
1401-
def set_vt(self, queue_name: str, msg_id: int, vt: int) -> Optional[Message]:
1402-
"""
1403-
Set the visibility timeout of a message.
1404-
1405-
Args:
1406-
queue_name (str): The name of the queue.
1407-
msg_id (int): The message ID.
1408-
vt (int): The new visibility timeout in seconds.
1409-
1410-
Returns:
1411-
|schema_message_class|_ or ``None`` if the message does not exist.
1412-
1413-
Usage:
1414-
1415-
.. code-block:: python
1416-
1417-
msg_id = pgmq_client.send('my_queue', {'key': 'value'})
1418-
msg = pgmq_client.read('my_queue', vt=10)
1419-
# extend the visibility timeout
1420-
msg = pgmq_client.set_vt('my_queue', msg_id, 20)
1421-
assert msg is not None
1422-
1423-
"""
1424-
if self.is_async:
1425-
return self.loop.run_until_complete(
1426-
self._set_vt_async(queue_name, msg_id, vt)
1427-
)
1428-
return self._set_vt_sync(queue_name, msg_id, vt)
1429-
14301369
def _detach_archive_sync(self, queue_name: str) -> None:
14311370
"""Detach the archive table for a queue synchronously."""
14321371
with self.session_maker() as session:

tests/test_queue.py

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,12 @@ def test_set_vt_to_smaller_value(pgmq_setup_teardown: PGMQ_WITH_QUEUE):
287287
assert pgmq.read(queue_name) is not None
288288

289289

290+
def test_set_vt_not_exist(pgmq_setup_teardown: PGMQ_WITH_QUEUE):
291+
pgmq, queue_name = pgmq_setup_teardown
292+
msg_updated = pgmq.set_vt(queue_name, 999, 20)
293+
assert msg_updated is None
294+
295+
290296
def test_pop(pgmq_setup_teardown: PGMQ_WITH_QUEUE):
291297
pgmq, queue_name = pgmq_setup_teardown
292298
msg = MSG
@@ -430,25 +436,6 @@ def test_metrics_all_queues(pgmq_setup_teardown: PGMQ_WITH_QUEUE):
430436
assert queue_2.total_messages == 2
431437

432438

433-
# Tests for set_vt method
434-
def test_set_vt(pgmq_setup_teardown: PGMQ_WITH_QUEUE):
435-
pgmq, queue_name = pgmq_setup_teardown
436-
msg = MSG
437-
msg_id = pgmq.send(queue_name, msg)
438-
msg_read = pgmq.read(queue_name, vt=10)
439-
assert msg_read.msg_id == msg_id
440-
# extend the visibility timeout
441-
msg_updated = pgmq.set_vt(queue_name, msg_id, 20)
442-
assert msg_updated is not None
443-
assert msg_updated.msg_id == msg_id
444-
445-
446-
def test_set_vt_not_exist(pgmq_setup_teardown: PGMQ_WITH_QUEUE):
447-
pgmq, queue_name = pgmq_setup_teardown
448-
msg_updated = pgmq.set_vt(queue_name, 999, 20)
449-
assert msg_updated is None
450-
451-
452439
# Tests for detach_archive method
453440
@pgmq_deps
454441
def test_detach_archive(pgmq_fixture, db_session):

0 commit comments

Comments
 (0)