Skip to content

Commit ff14f02

Browse files
committed
Choose runtime over typing for concrete vo
1 parent a37b4c9 commit ff14f02

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

src/app/domain/value_objects/raw_password.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
class RawPassword(ValueObject):
1010
"""raises DomainFieldError"""
1111

12-
value: str
12+
MIN_LEN: ClassVar[Final[int]] = 6
1313

14-
MIN_LEN: Final[ClassVar[int]] = 6
14+
value: str
1515

1616
def __post_init__(self) -> None:
1717
""":raises DomainFieldError:"""

src/app/domain/value_objects/username.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,29 +10,29 @@
1010
class Username(ValueObject):
1111
"""raises DomainFieldError"""
1212

13-
value: str
14-
15-
MIN_LEN: Final[ClassVar[int]] = 5
16-
MAX_LEN: Final[ClassVar[int]] = 20
13+
MIN_LEN: ClassVar[Final[int]] = 5
14+
MAX_LEN: ClassVar[Final[int]] = 20
1715

1816
# Pattern for validating a username:
1917
# - starts with a letter (A-Z, a-z) or a digit (0-9)
20-
PATTERN_START: Final[ClassVar[re.Pattern[str]]] = re.compile(
18+
PATTERN_START: ClassVar[Final[re.Pattern[str]]] = re.compile(
2119
r"^[a-zA-Z0-9]",
2220
)
2321
# - can contain multiple special characters . - _ between letters and digits,
24-
PATTERN_ALLOWED_CHARS: Final[ClassVar[re.Pattern[str]]] = re.compile(
22+
PATTERN_ALLOWED_CHARS: ClassVar[Final[re.Pattern[str]]] = re.compile(
2523
r"[a-zA-Z0-9._-]*",
2624
)
2725
# but only one special character can appear consecutively
28-
PATTERN_NO_CONSECUTIVE_SPECIALS: Final[ClassVar[re.Pattern[str]]] = re.compile(
26+
PATTERN_NO_CONSECUTIVE_SPECIALS: ClassVar[Final[re.Pattern[str]]] = re.compile(
2927
r"^[a-zA-Z0-9]+([._-]?[a-zA-Z0-9]+)*[._-]?$",
3028
)
3129
# - ends with a letter (A-Z, a-z) or a digit (0-9)
32-
PATTERN_END: Final[ClassVar[re.Pattern[str]]] = re.compile(
30+
PATTERN_END: ClassVar[Final[re.Pattern[str]]] = re.compile(
3331
r".*[a-zA-Z0-9]$",
3432
)
3533

34+
value: str
35+
3636
def __post_init__(self) -> None:
3737
""":raises DomainFieldError:"""
3838
super().__post_init__()

0 commit comments

Comments
 (0)