Fix role property naming

Author: ivan-borovets

src/app/domain/enums/user_role.py

@@ -11,5 +11,5 @@ def is_assignable(self) -> bool:
         return self != UserRole.SUPER_ADMIN
 
     @property
-    def is_modifiable(self) -> bool:
+    def is_changeable(self) -> bool:
         return self != UserRole.SUPER_ADMIN

src/app/domain/services/user.py

@@ -60,14 +60,14 @@ def toggle_user_activation(self, user: User, *, is_active: bool) -> None:
         """
         :raises ActivationChangeNotPermitted:
         """
-        if not user.role.is_modifiable:
+        if not user.role.is_changeable:
             raise ActivationChangeNotPermittedError(user.username, user.role)
         user.is_active = is_active
 
     def toggle_user_admin_role(self, user: User, *, is_admin: bool) -> None:
         """
         :raises RoleChangeNotPermitted:
         """
-        if not user.role.is_modifiable:
+        if not user.role.is_changeable:
             raise RoleChangeNotPermittedError(user.username, user.role)
         user.role = UserRole.ADMIN if is_admin else UserRole.USER

tests/app/unit/domain/enums/test_user_role.py

@@ -23,5 +23,5 @@ def test_assignability(role: UserRole, expected: bool) -> None:
         (UserRole.SUPER_ADMIN, False),
     ],
 )
-def test_modifiability(role: UserRole, expected: bool) -> None:
-    assert role.is_modifiable is expected
+def test_changeability(role: UserRole, expected: bool) -> None:
+    assert role.is_changeable is expected