Rename healthcheck endpoint, align CI

Author: ivan-borovets

.github/workflows/ci.yaml

@@ -28,30 +28,22 @@ jobs:
           export APP_ENV=local
           python config/toml_config_manager.py
           cd config/local
-          echo "Generated .env.local content:"
-          cat .env.local
           export COMPOSE_ENV_FILES=.env.local
           docker compose up -d --build
 
       - name: Verify Application Health
         run: |
-          timeout 10s bash -c '
-            while ! curl -sf http://0.0.0.0:9999/api/v1/; do
-              sleep 1
-            done
-          '
+          timeout 10s bash -s <<'BASH'
+          while ! curl -sf http://127.0.0.1:9999/api/v1/; do
+            sleep 1
+          done
+          BASH
 
       - name: Test Signup Handler
         run: |
-          timeout 10s bash -c "
-            while ! curl -sf -X POST \
-              'http://0.0.0.0:9999/api/v1/account/signup' \
-              -H 'accept: application/json' \
-              -H 'Content-Type: application/json' \
-              -d '{
-              \"username\": \"string\",
-              \"password\": \"string\"
-            }'; do
-              sleep 1
-            done
-          "
+          curl -f --json @- http://127.0.0.1:9999/api/v1/account/signup <<'JSON'
+          {
+            "username": "string",
+            "password": "string"
+          }
+          JSON

…/http/controllers/general/healthcheck.py …ation/http/controllers/general/health.pysrc/app/presentation/http/controllers/general/healthcheck.py renamed to src/app/presentation/http/controllers/general/health.py src/app/presentation/http/controllers/general/healthcheck.py renamed to src/app/presentation/http/controllers/general/health.py

@@ -2,11 +2,11 @@
 from starlette.requests import Request
 
 
-def create_healthcheck_router() -> APIRouter:
+def create_health_router() -> APIRouter:
     router = APIRouter()
 
     @router.get("/")
-    async def healthcheck(_: Request) -> dict[str, str]:
+    async def health(_: Request) -> dict[str, str]:
         """
         - Open to everyone.
         - Returns `200 OK` if the API is alive.

src/app/presentation/http/controllers/general/router.py

@@ -1,7 +1,7 @@
 from fastapi import APIRouter
 
-from app.presentation.http.controllers.general.healthcheck import (
-    create_healthcheck_router,
+from app.presentation.http.controllers.general.health import (
+    create_health_router,
 )
 
 
@@ -10,7 +10,7 @@ def create_general_router() -> APIRouter:
         tags=["General"],
     )
 
-    sub_routers = (create_healthcheck_router(),)
+    sub_routers = (create_health_router(),)
 
     for sub_router in sub_routers:
         router.include_router(sub_router)