[BUG]: Imports of github_actions_environment_variable Broken

[kyledecot]

Expected Behavior

If I have an existing environment in which some of the environment variables exist in Github and some do not yet exist running a apply should import existing resources and create missing resources.

Actual Behavior

Currently if the for_each block of an import points to a environment variable which does not yet exist apply will exit w/ a 404 instead of gracefully continuing and prompting that the resource will be created.

Terraform Version

Terraform v1.14.5
on darwin_arm64

Affected Resource(s)

• github_actions_environment_variable

Terraform Configuration Files

locals {
  variables = {
    FOO = "bar" # already exists (should be imported)
    HELLO = "world" # does not yet exist (should be created)
  }
}

import {
  for_each = local.variables

  id = "repo/staging/${each.key}"
  to = github_actions_environment_variable.variables[each.key]
}

resource "github_actions_environment_variable" "variables" {
  for_each = local.variables

  environment   = "staging"
  value         = each.value
  repository    = "repo"
  variable_name = each.key
}

Steps to Reproduce

terraform apply

Debug Output

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: GET https://api.github.com/repos/org/repo/environments/staging/variables/HELLO: 404 Not Found []

Panic Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[deiga]

AFAIK this is expected behaviour by terraform. Doing import on a nonexistent resource is an error.

I recommend you use list comprehension to filter out the collection in your import block