[BUG]: `allow_forking` seems to change on repo name update

[Low-Frequency]

Expected Behavior

Changing the name of a repo should not affect any other setting. Terraform plan seems fine.

Actual Behavior

When changing the name of a repo, terraform fails with the following error message:

PATCH https://api.github.com/repositories/: 422 Allow forks can only be changed on org-owned repositories []

There's no indication in the terraform plan, that this setting changes. Setting it explicitly to true, like it is in the terraform state doesn't change the behavior.

Terraform Version

Terraform v1.14.3
on linux_amd64

• provider registry.terraform.io/integrations/github v6.10.2

Affected Resource(s)

• github_repository

Terraform Configuration Files

Steps to Reproduce

main.tf:

terraform {
  required_version = "~> 1.14"
  required_providers {
    github = {
      source = "integrations/github"
      version = "~> 6.9"
    }
  }
}

variable "name" {
  type = string
}

resource "github_repository" "github_repo" {
  name = var.name
  visibility = "private"
  has_issues  = false
  has_discussions = false
  has_projects = false
  has_wiki = false
  archive_on_destroy = true

  ### Not set in initial test. Changing or omitting this doesn't affect the behavior
  allow_forking = true
}

terraform.tfvars:

name = "terraform-test"

### Change to this after initial apply to reproduce the error
# name = "terraform-test-01"

Terraform plan & apply:

$ terraform plan -out plan.tfplan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
Terraform will perform the following actions:
  # github_repository.github_repo will be updated in-place
  ~ resource "github_repository" "github_repo" {
      ~ full_name                   = "Low-Frequency/terraform-test" -> (known after apply)
        id                          = "infrastructure-prod-on-prem-server-mariadb"
      ~ name                        = "terraform-test" -> "terraform-test-01"

Plan: 0 to add, 1 to change, 0 to destroy.

$ terraform apply -input=false plan.tfplan
github_repository.github_repo: Modifying... [id=terraform-test]
╷
│ Error: PATCH https://api.github.com/repositories/<ID>: 422 Allow forks can only be changed on org-owned repositories []
│ 
│   with github_repository.github_repo,
│   on .terraform/main.tf line 64, in resource "github_repository" "github_repo":
│   64: resource "github_repository" "github_repo" {
│ 
╵

Debug Output

Panic Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[Low-Frequency]

Further info:

The same behavior can be reproduced by changing the archive_on_destroy parameter.

[Low-Frequency]

Only workaround I have found are lifecycle rules:

resource "github_repository" "github_repo" {
  name = var.name
  visibility = "private"
  has_issues  = false
  has_discussions = false
  has_projects = false
  has_wiki = false
  archive_on_destroy = true
  allow_forking = true

  lifecycle {
    ignore_changes = [
      archive_on_destroy,
      allow_forking
    ]
  }
}

With this it gets usable again, but this shouldn't be necessary.

[deiga]

@Low-Frequency I'm sorry you're having issues with this! And big thanks for reporting it! 🙏

You mention that the issue is only when changing name or changing archive_on_destroy, does that mean you tried other changes which didn't have this impact?

Edit: Are you using the latest provider version? The config states ~>6.9, so just making sure you're using 6.10.2

[Low-Frequency]

@deiga Thanks for the quick reply!

I haven't tested any other changes, since these were the only pending changes shown in my pipeline, but I can easily setup a testing environment for this. It might take some time, since I'm pretty busy the next few days, but I'll report back when I have run more tests.

Good point regarding the config, I should update that. However I've checked the pipeline and it's definitely using 6.10.2

[stevehipwell]

@Low-Frequency this should be fixed by #3127 which will be released in the next version.