[BUG]: `github_team_settings` churn with `review_request_delegation`

[faximan]

Expected Behavior

This block is applied once:

resource "github_team_settings" "team_releng_settings" {
  team_id = github_team.team_releng.id
  review_request_delegation {
    algorithm    = "ROUND_ROBIN"
    member_count = 1
    notify       = false
  }
}

Actual Behavior

In every new plan, I'm seeing this diff

  # github_team_settings.team_releng_settings will be updated in-place
!   resource "github_team_settings" "team_releng_settings" {
        id        = "T_kwDOBj62P84A8aGO"
        # (3 unchanged attributes hidden)

+       review_request_delegation {
+           algorithm    = "ROUND_ROBIN"
+           member_count = 1
+           notify       = false
        }
    }

Terraform Version

Terraform 1.11.4

registry.terraform.io/integrations/github 6.10.2 (this seems to not have been an issue on 6.9.1 which we just updated from).

Affected Resource(s)

• github_team_settings

Terraform Configuration Files

resource "github_team" "team_releng" {
  name        = "RelEng"
  description = "Release Engineering"
  privacy     = "closed"
}

resource "github_team_settings" "team_releng_settings" {
  team_id = github_team.team_releng.id
  review_request_delegation {
    algorithm    = "ROUND_ROBIN"
    member_count = 1
    notify       = false
  }
}

Steps to Reproduce

terraform apply
# team_releng_settings: changes successfully applied
terraform plan
# > diffs from above are present again

Debug Output

Looking directly into the state file post-apply, we see the resource there successfully. Interestingly, we have other similar resources with exactly the same config and state presence, and they do _not_ show up in the `terraform plan`


team_releng_settings
    {
      "mode": "managed",
      "type": "github_team_settings",
      "name": "team_releng_settings",
      "provider": "provider[\"registry.terraform.io/integrations/github\"]",
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "id": "T_kwDOBj62P84A8aGO",
            "review_request_delegation": [
              {
                "algorithm": "ROUND_ROBIN",
                "member_count": 1,
                "notify": false
              }
            ],
            "team_id": "15835534",
            "team_slug": "releng",
            "team_uid": "T_kwDOBj62P84A8aGO"
          },
          "sensitive_attributes": [],
          "private": "bnVsbA==",
          "dependencies": [
            "github_team.team_releng"
          ]
        }
      ]
    },
    {
      "mode": "managed",
      "type": "github_team_settings",
      "name": "team_sdk_settings",
      "provider": "provider[\"registry.terraform.io/integrations/github\"]",
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "id": "T_kwDOBj62P84AxH04",
            "review_request_delegation": [
              {
                "algorithm": "ROUND_ROBIN",
                "member_count": 1,
                "notify": false
              }
            ],
            "team_id": "12877112",
            "team_slug": "sdk",
            "team_uid": "T_kwDOBj62P84AxH04"
          },
          "sensitive_attributes": [],
          "private": "bnVsbA==",
          "dependencies": [
            "github_team.team_sdk"
          ]
        }
      ]
    }
  ],
  "check_results": null
}

Panic Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[deiga]

Hey @faximan 👋
Are you able to reproduce this on the latest provider version? If yes, could you please add DEBUG level output from the plan command?

[faximan]

Hey! In the end we ran a terraform state rm on this and started over. It is all good now, so I'm not sure what happened before. Feel free to close if you want and thanks for taking a look.