[BUG]: github_organization_custom_properties 404 Not Found

[yannickvr]

Expected Behavior

Adding or editiong github_organization_custom_properties should add/update property

Actual Behavior

╷
│ Error: PUT https://api.github.com/orgs/MYORG/properties/schema/iac: 404 Not Found []
│ 
│   with github_organization_custom_properties.this["iac"],
│   on main.tf line 84, in resource "github_organization_custom_properties" "this":
│   84: resource "github_organization_custom_properties" "this" {
│ 

Terraform Version

Terraform v1.13.4
on darwin_arm64

• provider registry.terraform.io/integrations/github v6.9.1

Affected Resource(s)

• github_organization_custom_properties

Terraform Configuration Files

resource "github_organization_custom_properties" "this" {
  for_each = local.organization_custom_properties

  property_name      = each.value.property_name
  value_type         = each.value.value_type
  required           = each.value.required
  description        = try(each.value.description, null)
  default_value      = try(each.value.default_value, null)
  allowed_values     = try(each.value.allowed_values, null)
  values_editable_by = try(each.value.values_editable_by, "org_actors")
}

Steps to Reproduce

terraform apply

Debug Output

Panic Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[stevehipwell]

@yannickvr do you have the correct permissions to call this endpoint?

[yannickvr]

@yannickvr do you have the correct permissions to call this endpoint?

@stevehipwell ah. I am organization owner, so assumed as much. However on verifying that this was a TF issue and not a GH issue and trying to add a custom property via the API, the GH CLI gave the answer: you need to get a token that's scoped for org admin:

gh auth refresh -h github.com -s admin:org

I think it would be good if 404's on organization resources would give this suggestion in Terraform as well, or at least mention it in the readme here: https://registry.terraform.io/providers/integrations/github/latest/docs#authentication

[deiga]

I agree that it would be lovely and I think we used to have that, but it's possible that the go-github SDK is swallowing some errors after some GitHub API structure changes

[stevehipwell]

We should link to the REST API docs from the TF resource docs as it clearly states the permissions required. FYI if you search on this issue (or similar one) you'll see that the GitHub REST API will use a 404 response for lack of permissions.