[BUG]: `team_id` forces convert to int format when creating `github_team_repository` resource

[iv0rish]

Expected Behavior

Create github_team_repository resource with teamId or slug starting with 0.

Actual Behavior

We have hundreds of teams which both team_id and slug starts with 0.

When creating github_team_repository resource, teamId is being converted from a string to an integer, and team IDs that start with zero are being automatically altered. For example, if teamId is 000123, it is converted to 123 when the API request is made.

I think the snippet below is affecting to this issue when creating the resource

d.SetId(buildTwoPartID(strconv.FormatInt(teamId, 10), repoName))

Only creating the resource is the issue, read / update / delete action does not change the string format.

Terraform Version

Terraform v1.9.8
on linux_amd64

and

Terraform v1.13.2
on darwin_arm64

Affected Resource(s)

• github_team_reopsitory

Terraform Configuration Files

Steps to Reproduce

Sample resource block

resource "github_team_repository" "team_repo" {
  for_each = { for k, v in local.collab : v.team_id => v }

  team_id      = local.collab.team_id
  repository  = local.collab.repository
  permission = local.collab.permission

}

locals {
  collab = {
    team_id      = "000123"
    repository  = {REPO}
    permission = "pull"
  }
}

When applying:

github_team_repository.team_repo["000123"]: Creating...


Error: PUT https://{GITHUB_HOST}/api/v3/organizations/{ORG}/team/123/repos/{OWNER}/{REPO}: 404 Not Found []

 with github_team_repository.team_repo["000123"]:
1 : resource "github_team_repository" "team_repo" {

Operation failed: failed running terraform apply (exit 1)

Debug Output

Panic Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[deiga]

Hey 👋

Thanks for raising this issue. This is definitely a problem as we allow the team_id be either a slug or an integer ID.
So, there isn't a straightforward way to fix this.

Are you able to use any non-number character as a prefix for now?

And out of curiosity: How come you use numeric team names?

I think that the conversion issue comes from

terraform-provider-github/github/resource_github_team_repository.go

Line 76 in 63076f7

teamId, err := getTeamID(givenTeamId, meta)

and not the snippet you marked

[stevehipwell]

This is a known issue with the current provider version, you should use the team ID rather than the slug as it should stop issues like this and requires fewer API calls. Note that the API endpoint you're hitting is for the team ID, the team slug endpoint is subtly different.

We currently have #3044 (and #2497) to actually fix this issue, but I think that #2421 would also help here.

[iv0rish]

Hi @deiga ,

We are using the numeric ID of the team(OU) created in LDAP as the team name. Since the organization has a very large number of teams and team names change frequently, the OU ID serves as a unique identifier. Because there are thousands of teams, adding a prefix to every team is practically impossible.

And @stevehipwell , thank you for providing more information and sorry to hear that those PRs are still not getting any response.
Additionally, when the slug is numeric, the values of the slug and teamId are set to be the same, which causes an error regardless of which one is specified. I’m not sure whether this behavior is the same in the GitHub Cloud, but we have confirmed it at least in GitHub Enterprise Server.

There should be a way to handle teamId as a string without converting it to an integer.

[stevehipwell]

We are using the numeric ID of the team(OU) created in LDAP as the team name. Since the organization has a very large number of teams and team names change frequently, the OU ID serves as a unique identifier. Because there are thousands of teams, adding a prefix to every team is practically impossible.

And @stevehipwell , thank you for providing more information and sorry to hear that those PRs are still not getting any response.
Additionally, when the slug is numeric, the values of the slug and teamId are set to be the same, which causes an error regardless of which one is specified. I’m not sure whether this behavior is the same in the GitHub Cloud, but we have confirmed it at least in GitHub Enterprise Server.

There should be a way to handle teamId as a string without converting it to an integer.

I'm not sure I follow your usage here. To create a team you provide a team name and GitHub creates the team ID and slug. The name and slug will match if the name meets the criteria for a slug but the ID will be a random int64; so I don't see how "the values of the slug and teamId are set to be the same" can be true?

Looking at your code it appears that you're confusing your local team_id value with the actual team ID which is an int64 (so can't have a 0 prefix). If you need to support this pattern and you don't have access to the actual team ID you can use the github_team data source to get it from the slug (just remember to set summary_only = true).

[stevehipwell]

@iv0rish have you read my last comment and been able to resolve your issue?

[stevehipwell]

@iv0rish just following up to see if I can close this issue?

[deiga]

Closing due to inactivity and lack of reproduction information