Fix TestAccGithubRepositoryCollaborators to not use external user

Signed-off-by: Timo Sand <[email protected]>

Author: deiga

github/resource_github_repository_collaborators_test.go

@@ -96,6 +96,7 @@ func TestAccGithubRepositoryCollaborators(t *testing.T) {
 		randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
 		repoName := fmt.Sprintf("%srepo-collabs-%s", testResourcePrefix, randomID)
 		teamName := fmt.Sprintf("%steam-collabs-%s", testResourcePrefix, randomID)
+		collaboratorUser := testAccConf.testOrgUser
 
 		config := fmt.Sprintf(`
 			resource "github_repository" "test" {
@@ -121,7 +122,7 @@ func TestAccGithubRepositoryCollaborators(t *testing.T) {
 					permission = "pull"
 				}
 			}
-		`, repoName, teamName, testAccConf.testExternalUser)
+		`, repoName, teamName, collaboratorUser)
 
 		resource.Test(t, resource.TestCase{
 			PreCheck:          func() { skipUnlessHasOrgs(t) },
@@ -140,8 +141,8 @@ func TestAccGithubRepositoryCollaborators(t *testing.T) {
 							teamAttrs := state.RootModule().Resources["github_team.test"].Primary.Attributes
 							collaborators := state.RootModule().Resources["github_repository_collaborators.test_repo_collaborators"].Primary
 							for name, val := range collaborators.Attributes {
-								if strings.HasPrefix(name, "user.") && strings.HasSuffix(name, ".username") && val != testAccConf.testExternalUser {
-									return fmt.Errorf("expected user.*.username to be set to %s, was %s", testAccConf.testExternalUser, val)
+								if strings.HasPrefix(name, "user.") && strings.HasSuffix(name, ".username") && val != collaboratorUser {
+									return fmt.Errorf("expected user.*.username to be set to %s, was %s", collaboratorUser, val)
 								}
 								if strings.HasPrefix(name, "user.") && strings.HasSuffix(name, ".permission") && val != "admin" {
 									return fmt.Errorf("expected user.*.permission to be set to admin, was %s", val)
@@ -158,11 +159,11 @@ func TestAccGithubRepositoryCollaborators(t *testing.T) {
 								return err
 							}
 							if len(users) != 1 {
-								return fmt.Errorf("expected %s to be a collaborator for repo %s/%s", testAccConf.testExternalUser, owner, repoName)
+								return fmt.Errorf("expected 1 collaborator (%s) for repo %s/%s , found %d", collaboratorUser, owner, repoName, len(users))
 							}
 							perm := getPermission(users[0].GetRoleName())
 							if perm != "admin" {
-								return fmt.Errorf("expected %s to have admin perms for repo %s/%s, found %s", testAccConf.testExternalUser, owner, repoName, perm)
+								return fmt.Errorf("expected %s to have admin perms for repo %s/%s, found %s", collaboratorUser, owner, repoName, perm)
 							}
 							teams, _, err := conn.Repositories.ListTeams(ctx, owner, repoName, nil)
 							if err != nil {